Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Raytac MDBT50Q Module #2390

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Add Raytac MDBT50Q Module #2390

merged 3 commits into from
Sep 28, 2020

Conversation

soburi
Copy link
Contributor

@soburi soburi commented Aug 12, 2020

Datasheet:
https://www.raytac.com/download/index.php?index_id=43

Related drawing in DS:
datasheet_pin_dimension
datasheet_fp_attern

ScreenShot:
screenshot_fp

Symbol PR is KiCad/kicad-symbols#2910.
3D Models PR is KiCad/kicad-packages3D-source#288 and KiCad/kicad-packages3D#718.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Aug 13, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Sep 28, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 28, 2020
@myfreescalewebpage
Copy link
Collaborator

@soburi starting review of the footprint:

  • The symbol should be vertically centered. Every thing to be moved down by 1.75mm
  • F.Fab: an indicator near to pin 1 is required. We usually used a triangle see for example BeagleBoard_PocketBeagle
  • F.SilkS: we usually use a line or a triangle, see BeagleBoard_PocketBeagle

Else looks good, position and size of the pins and keep out zone verified ok

Joel

Add short line to F.SilkS layer to indicate pin-1.
Add triangle sign to F.Fab layer to indicate pin-1.
@soburi
Copy link
Contributor Author

soburi commented Sep 28, 2020

Hi! @myfreescalewebpage.

Thank you for reviewing.

Fix problems that pointing out in your comments.

  • The symbol should be vertically centered. Every thing to be moved down by 1.75mm
  • F.Fab: an indicator near to pin 1 is required. We usually used a triangle see for example BeagleBoard_PocketBeagle
  • F.SilkS: we usually use a line or a triangle, see BeagleBoard_PocketBeagle

SnapCrab_フットプリント エディター — RF_ModuleRaytac_MDBT50Q _2020-9-28_23-7-32_No-00

Regards.

@myfreescalewebpage
Copy link
Collaborator

Thanks, no more comment, merging.

@myfreescalewebpage myfreescalewebpage merged commit a75a4ea into KiCad:master Sep 28, 2020
@soburi soburi deleted the mdbt50q branch September 28, 2020 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants