Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Rayac MDBT50Q Module #2910

Merged
merged 11 commits into from
Sep 28, 2020
Merged

Add Rayac MDBT50Q Module #2910

merged 11 commits into from
Sep 28, 2020

Conversation

soburi
Copy link
Contributor

@soburi soburi commented Aug 12, 2020

Add Rayac MDBT50Q Module

Datasheet:
https://www.raytac.com/download/index.php?index_id=43
https://www.raytac.com/download/index.php?index_id=46

ScreenShot:
mdbt50q-1mv
mdbt50q-512k

Footprint PR is KiCad/kicad-footprints#2390.


  • Provide a URL to a datasheet for [the] symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprint
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2020

CLA assistant check
All committers have signed the CLA.

@soburi
Copy link
Contributor Author

soburi commented Aug 12, 2020

   Specified footprint does not exist

     - Footprint file RF_Module:Raytac_MDBT50Q was not found

Footprint file will be available with KiCad/kicad-footprints#2390 accepted, I think there should be no problem at this point.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer labels Aug 13, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 26, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 26, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 26, 2020

Hi @soburi , thanks for contributing,

A few comments I have during my review:

MDBT50Q-1MV2

  • Pin length should be 100mil for this symbol
  • Name of pin 17 should be XL1/P0.00 to have main function on the border
  • Name of pin 18 should be XL2/P0.01 to have main function on the border
  • Name of pin 23 should be TRACECLK/P0.07 to have main function on the border + same comment for TRACEDATA pins
  • Pin 25 P1.08 should be below pin 58 P1.07
  • Pin 51 SWDIO is Bidirectional
  • D+ and D- are Bidirectional

MDBT50Q-512K

  • Pin length should be 100mil for this symbol
  • Name of pin 17 should be XL1/P0.00 to have main function on the border
  • Name of pin 18 should be XL2/P0.01 to have main function on the border
  • Name of pin 23 should be TRACECLK/P0.07 to have main function on the border + same comment for TRACEDATA pins
  • Pin 25 P1.08 should be below pin 58 P1.07
  • Pin 51 SWDIO is Bidirectional
  • D+ and D- are Bidirectional
  • Pin 42 is NC

Cheers,
Joel

soburi added 10 commits August 27, 2020 13:19
Change the electrical type of D+, D-, and SWDIO to bidirectional.
Place the main function name on the border side

P0.00/XL1        ->        XL1/P0.00
P0.01/XL2        ->        XL2/P0.01
P0.07/TRACECLK   ->   TRACECLK/P0.07
P1.00/TRACEDATA0 -> TRACEDATA0/P1.00
P0.12/TRACEDATA1 -> TRACEDATA1/P0.12
P0.11/TRACEDATA2 -> TRACEDATA2/P0.11
P1.09/TRACEDATA3 -> TRACEDATA3/P1.09
Change the electrical type of D+, D-, and SWDIO to bidirectional.
Change pin42 to NC.
Place the main function name on the border side

P0.00/XL1        ->        XL1/P0.00
P0.01/XL2        ->        XL2/P0.01
P0.07/TRACECLK   ->   TRACECLK/P0.07
P1.00/TRACEDATA0 -> TRACEDATA0/P1.00
P0.12/TRACEDATA1 -> TRACEDATA1/P0.12
P0.11/TRACEDATA2 -> TRACEDATA2/P0.11
P1.09/TRACEDATA3 -> TRACEDATA3/P1.09
@soburi
Copy link
Contributor Author

soburi commented Aug 27, 2020

Hi! @myfreescalewebpage.

Thank you for reviewing.

Fix problems that pointing out in your comments.

And additionally fix the function name order of P0.18/~RESET.
(The pin act as GPIO at default. Change the same as MCU_Nordic:nRF52840 symbol's notation.)

Regards.

SnapCrab_Symbol Editor — RF_ModuleMDBT50Q-1MV2_2020-8-27_18-26-53_No-00

SnapCrab_Symbol Editor — RF_ModuleMDBT50Q-512K_2020-8-27_18-27-6_No-00

@myfreescalewebpage
Copy link
Collaborator

Thanks, great job ! No more comment to do, just need to wait the footprint.

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Sep 28, 2020
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage
Copy link
Collaborator

Merging following integration of fp

@myfreescalewebpage myfreescalewebpage merged commit ad22118 into KiCad:master Sep 28, 2020
@soburi soburi deleted the mdbt50q branch September 28, 2020 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants