This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2020
Footprint file will be available with KiCad/kicad-footprints#2390 accepted, I think there should be no problem at this point. |
myfreescalewebpage
added
Addition
Adds new symbols to library
Pending footprint
Pending footprint acceptance before merging
Pending reviewer
A pull request waiting for a reviewer
labels
Aug 13, 2020
myfreescalewebpage
removed
the
Pending reviewer
A pull request waiting for a reviewer
label
Aug 26, 2020
Hi @soburi , thanks for contributing, A few comments I have during my review: MDBT50Q-1MV2
MDBT50Q-512K
Cheers, |
Change the electrical type of D+, D-, and SWDIO to bidirectional.
Place the main function name on the border side P0.00/XL1 -> XL1/P0.00 P0.01/XL2 -> XL2/P0.01 P0.07/TRACECLK -> TRACECLK/P0.07 P1.00/TRACEDATA0 -> TRACEDATA0/P1.00 P0.12/TRACEDATA1 -> TRACEDATA1/P0.12 P0.11/TRACEDATA2 -> TRACEDATA2/P0.11 P1.09/TRACEDATA3 -> TRACEDATA3/P1.09
Change the electrical type of D+, D-, and SWDIO to bidirectional. Change pin42 to NC.
Place the main function name on the border side P0.00/XL1 -> XL1/P0.00 P0.01/XL2 -> XL2/P0.01 P0.07/TRACECLK -> TRACECLK/P0.07 P1.00/TRACEDATA0 -> TRACEDATA0/P1.00 P0.12/TRACEDATA1 -> TRACEDATA1/P0.12 P0.11/TRACEDATA2 -> TRACEDATA2/P0.11 P1.09/TRACEDATA3 -> TRACEDATA3/P1.09
Hi! @myfreescalewebpage. Thank you for reviewing. Fix problems that pointing out in your comments. And additionally fix the function name order of P0.18/~RESET. Regards. |
Thanks, great job ! No more comment to do, just need to wait the footprint. |
myfreescalewebpage
removed
the
Pending footprint
Pending footprint acceptance before merging
label
Sep 28, 2020
Closing/opening to refresh the Travis test. |
Merging following integration of fp |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Rayac MDBT50Q Module
Datasheet:
https://www.raytac.com/download/index.php?index_id=43
https://www.raytac.com/download/index.php?index_id=46
ScreenShot:
Footprint PR is KiCad/kicad-footprints#2390.
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.