Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): combine services across httproutes expression router #6766

Merged
merged 3 commits into from
Dec 11, 2024

address comments

5eb89d1
Select commit
Loading
Failed to load commit list.
Merged

feat(translator): combine services across httproutes expression router #6766

address comments
5eb89d1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 0s

79.0% (+1.2%) compared to 4f6373f

View this Pull Request on Codecov

79.0% (+1.2%) compared to 4f6373f

Details

Codecov Report

Attention: Patch coverage is 86.36364% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (4f6373f) to head (5eb89d1).

Files with missing lines Patch % Lines
...al/dataplane/translator/subtranslator/httproute.go 83.3% 4 Missing and 2 partials ⚠️
...ataplane/translator/subtranslator/httproute_atc.go 89.6% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #6766     +/-   ##
=======================================
+ Coverage   77.7%   79.0%   +1.2%     
=======================================
  Files        208     208             
  Lines      24833   24766     -67     
=======================================
+ Hits       19314   19579    +265     
+ Misses      4539    4191    -348     
- Partials     980     996     +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov