Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no JSON whitespace in release version #886

Closed
wants to merge 2 commits into from

Conversation

fr-an-k
Copy link
Contributor

@fr-an-k fr-an-k commented Dec 2, 2023

Saves almost half the size; I plan to use this in a javascript production environment.

@fr-an-k fr-an-k closed this Dec 2, 2023
Copy link
Contributor

@rurban rurban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, but better as runtime cmdline switch. like --json-compact or so

and without dxfread

rurban added a commit that referenced this pull request Feb 7, 2024
no whitespace at run-time.
We don't write minimal JSON as with minimal DXFs anymore
($ACADVER, $HANDSEED, and then ENTITIES only).
With ideas from GH #886
@rurban
Copy link
Contributor

rurban commented Feb 7, 2024

I've used now --fmt=minJSON or --outfile=xxx.min.json for this feature. And your FSF CLA doesn't come along in time

@rurban
Copy link
Contributor

rurban commented Feb 7, 2024

see smoke/minjson-gh886

@rurban rurban self-assigned this Feb 7, 2024
@rurban rurban added the enhancement New feature or request label Feb 7, 2024
@rurban rurban added this to the 0.13.2 milestone Feb 7, 2024
rurban added a commit that referenced this pull request Feb 7, 2024
no whitespace at run-time.
We don't write minimal JSON as with minimal DXFs anymore
($ACADVER, $HANDSEED, and then ENTITIES only).
With ideas from GH #886
rurban added a commit that referenced this pull request Feb 7, 2024
no whitespace at run-time.
We don't write minimal JSON as with minimal DXFs anymore
($ACADVER, $HANDSEED, and then ENTITIES only).
With ideas from GH #886
rurban added a commit that referenced this pull request Feb 8, 2024
no whitespace at run-time.
We don't write minimal JSON as with minimal DXFs anymore
($ACADVER, $HANDSEED, and then ENTITIES only).
With ideas from GH #886
rurban added a commit that referenced this pull request Feb 8, 2024
no whitespace at run-time.
We don't write minimal JSON as with minimal DXFs anymore
($ACADVER, $HANDSEED, and then ENTITIES only).
With ideas from GH #886
rurban added a commit that referenced this pull request Feb 8, 2024
no whitespace at run-time.
We don't write minimal JSON as with minimal DXFs anymore
($ACADVER, $HANDSEED, and then ENTITIES only).
With ideas from GH #886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants