Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicQuantities to 0.10 #264

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2023

This pull request changes the compat entry for the DynamicQuantities package from 0.7 to 0.10.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2023-11-03-00-09-25-600-02903764031 branch from 3127730 to 18801be Compare November 3, 2023 00:09
@MilesCranmer MilesCranmer force-pushed the compathelper/new_version/2023-11-03-00-09-25-600-02903764031 branch from fe200cf to 351393d Compare November 13, 2023 01:23
Copy link
Contributor Author

github-actions bot commented Nov 13, 2023

Benchmark Results

master f25b3a4... t[master]/t[f25b3a4...]
search/multithreading 25.5 ± 3 s 25.5 ± 1.9 s 1
search/serial 31.4 ± 0.58 s 31.4 ± 0.61 s 0.999
time_to_load 1.75 ± 0.0093 s 1.94 ± 0.0047 s 0.903
utils/best_of_sample 0.782 ± 0.23 μs 0.771 ± 0.24 μs 1.01
utils/check_constraints_x10 12.7 ± 3.2 μs 12.5 ± 3.2 μs 1.01
utils/compute_complexity_x10/Float64 2.31 ± 0.11 μs 2.35 ± 0.12 μs 0.983
utils/compute_complexity_x10/Int64 2.31 ± 0.11 μs 2.32 ± 0.12 μs 0.996
utils/compute_complexity_x10/nothing 1.61 ± 0.1 μs 1.52 ± 0.11 μs 1.06
utils/optimize_constants_x10 29.4 ± 6.5 ms 29.2 ± 6.1 ms 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

src/MLJInterface.jl Outdated Show resolved Hide resolved
@MilesCranmer MilesCranmer changed the title CompatHelper: bump compat for DynamicQuantities to 0.8, (keep existing compat) CompatHelper: bump compat for DynamicQuantities to 0.10 Dec 11, 2023
@MilesCranmer MilesCranmer merged commit debe0de into master Dec 11, 2023
18 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2023-11-03-00-09-25-600-02903764031 branch December 11, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant