Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicQuantities to 0.10 #264

Merged
merged 12 commits into from
Dec 11, 2023
Merged

CompatHelper: bump compat for DynamicQuantities to 0.10 #264

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
18801be
CompatHelper: bump compat for DynamicQuantities to 0.8, (keep existin…
Nov 3, 2023
cc4712c
Bump to 0.9 of DynamicQuantities
MilesCranmer Nov 13, 2023
351393d
Fix constructorof import
MilesCranmer Nov 13, 2023
11e68fc
Fix unit stripping
MilesCranmer Nov 13, 2023
28d4885
Fix formatting
MilesCranmer Nov 13, 2023
4c790ff
Fix Aqua compat
MilesCranmer Dec 9, 2023
44a2ebf
Update compat for DynamicQuantities
MilesCranmer Dec 9, 2023
8b8d841
Clean up DynamicQuantities interface
MilesCranmer Dec 9, 2023
888c4b9
Generalize `get_dimensions_type`
MilesCranmer Dec 10, 2023
2bd30db
Test RealQuantity as well
MilesCranmer Dec 10, 2023
054d6aa
Cleanup
MilesCranmer Dec 10, 2023
f25b3a4
Add missing import for RealQuantity
MilesCranmer Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/MLJInterface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ end
function unwrap_units_single(A::AbstractMatrix, ::Type{D}) where {D}
return A, [D() for _ in eachrow(A)]
end
function unwrap_units_single(A::AbstractMatrix{T}, ::Type{D}) where {D,T<:UnionAbstractQuantity}
function unwrap_units_single(
A::AbstractMatrix{T}, ::Type{D}
) where {D,T<:UnionAbstractQuantity}
for (i, row) in enumerate(eachrow(A))
allequal(Base.Fix2(dimension_fallback, D).(row)) ||
error("Inconsistent units in feature $i of matrix.")
Expand All @@ -321,7 +323,9 @@ end
function unwrap_units_single(v::AbstractVector, ::Type{D}) where {D}
return v, D()
end
function unwrap_units_single(v::AbstractVector{T}, ::Type{D}) where {D,T<:UnionAbstractQuantity}
function unwrap_units_single(
v::AbstractVector{T}, ::Type{D}
) where {D,T<:UnionAbstractQuantity}
MilesCranmer marked this conversation as resolved.
Show resolved Hide resolved
allequal(Base.Fix2(dimension_fallback, D).(v)) || error("Inconsistent units in vector.")
dims = dimension_fallback(first(v), D)
v = ustrip.(v)
Expand Down
Loading