Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update reqwest, object-store #18789

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Jul 24, 2024

Update a number of http related libraries, including but not limited to:

  • reqwest
  • object-store

A future PR will continue by upgrading anemo, rustls, hyper

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Jul 24, 2024

@bmwill is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 3:15pm

@stefan-mysten
Copy link
Contributor

You are brave @bmwill! I started doing the same with hyper, axum, and http and started pulling white hairs soon after 🦀

@stefan-mysten
Copy link
Contributor

I am slightly worried about upgrading to a new async-graphql version before we do this new major release.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@bmwill bmwill changed the title chore: update hyper et al chore: update reqwest, object-store Jul 25, 2024
Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmwill

@bmwill bmwill merged commit 255d868 into MystenLabs:main Jul 25, 2024
41 of 45 checks passed
@bmwill bmwill deleted the update-http branch July 25, 2024 15:46
amnn added a commit that referenced this pull request Jul 30, 2024
amnn added a commit that referenced this pull request Jul 30, 2024
## Description

Pick PRs to introduce the `ConsensusCommitPrologueV3` types into the
(soon-to-be legacy) GraphQL release branch, so that it can continue
deserializing transaction blocks and effects.

Cherry picks include: #17678, #18816, #18789 (+ a pick to `fastcrypto`
to use `reqwest 0.12`).

## Test plan

```
sui$ cargo simtest
sui-graphql-rpc$ cargo nextest run
sui-graphql-e2e-tests$ cargo nextest run --features pg_integration
```

and CI

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:

---------

Co-authored-by: Brandon Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants