Add Load and Activate Real Time Commands to SeqN

[goetzrrGit]

Summary
Added immediate_activate and immediate_load to SeqN.

@IMMEDIATE
ECHO "" 
@LOAD("seqA")

SeqJson

{
  "id": "SeqC",
  "metadata": {},
  "immediate_commands": [
    {
      "args": [
        {
          "type": "string",
          "value": "",
          "name": "echo_string"
        }
      ],
      "stem": "ECHO",
      "type": "command"
    },
    {
      "args": [],
      "sequence": "seqA",
      "type": "load"
    }
  ]
}

[joswig]

Test cases and functionality are good.

My comment on the seq-json types is because distinct literal values help with control flow analysis. It also feels like we have a lot of type assertions.

[joswig]

Can we use a different type attribute on Activate and ImmediateActivate in seq-json-schema? Same thing for Load and ImmediateLoad?

https://github.com/NASA-AMMOS/seq-json-schema/blob/04bc2f98b377cc0edb2ff06620605c0eca3a02f5/schema.json#L37

[goetzrrGit]

Still a little confused about you comment Did you want me to split this up like below

  if (stepNode.name === 'Activate') {
    return {
      args,
      description,
      engine,
      epoch,
      metadata,
      models,
      sequence,
      ...(!isRTC ? { time } : {}),
      type: 'activate',
    };
  }
  return {
    args,
    description,
    engine,
    epoch,
    metadata,
    models,
    sequence,
    ...(!isRTC ? { time } : {}),
    type: 'load',
  };

Or did you want to go to the schema and change ImmediateActivate's type to type: "immediate_activate" Similar with Load

[goetzrrGit]

The current schema change was what @cartermak, Mike Schaffer, and I agreed on so we will have to go back to them and see if they are okay with changing this.

[duranb]

Can we also split this up so it's clear what logic branch generated what type?

[cartermak]

Sorry for the slow reply -- I don't see an issue with amending the type attribute on the immediate activate and load steps to say immediate_load and immediate_activate, although it is redundant with those objects being in the immediate_commands array.

[goetzrrGit]

To be consistent, I think you will need to change the ImmediateFswCommand object type as well to type: 'ImmediateFswCommand';

export interface ImmediateFswCommand {
  args: Args;
  description?: Description;
  metadata?: Metadata;
  /**
   * Command stem
   */
  stem: string;
  type?: 'command'; <----- Change to ImmediateFswCommand
}

[goetzrrGit]

@joswig new schema changes in place now. I am also using overloaded methods

[duranb]

Can we also split this up so it's clear what logic branch generated what type?