Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTC's Type #29

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Update RTC's Type #29

merged 3 commits into from
Dec 9, 2024

Conversation

goetzrrGit
Copy link
Contributor

@goetzrrGit goetzrrGit commented Nov 22, 2024

I updated the immediate_load and immediate_activate types to be specific

ex.

immediate_load{
        "args": {
          "$ref": "#/$defs/args"
        },
        "description": {
          "$ref": "#/$defs/description"
        },
        "engine": {
          "type": "integer",
          "description": "Sequence target engine."
        },
        "type": {
          "const": "load" <------------------------ making this 'immediate_load'
        }
}

Also for consistency I added model attribute from immediateFSWCommands. I verified with Taifun, Carter, and Mike Schaffer of these changes and they were onboard with it.

@goetzrrGit goetzrrGit marked this pull request as draft November 22, 2024 19:35
@goetzrrGit goetzrrGit force-pushed the feature/update_rtc_type branch from 5a83b57 to 2ca47a8 Compare December 2, 2024 21:24
@goetzrrGit goetzrrGit marked this pull request as ready for review December 2, 2024 21:28
@goetzrrGit goetzrrGit self-assigned this Dec 3, 2024
Copy link
Collaborator

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@cartermak cartermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than version increment.

package.json Outdated Show resolved Hide resolved
@goetzrrGit goetzrrGit force-pushed the feature/update_rtc_type branch from 2ca47a8 to b8fed7c Compare December 6, 2024 18:45
@goetzrrGit goetzrrGit requested a review from cartermak December 6, 2024 18:46
* update types to immediate_load, immediate_activate, immediate_command
* remove model from immediate_load and imediate_activate
@goetzrrGit goetzrrGit force-pushed the feature/update_rtc_type branch from b8fed7c to 7209165 Compare December 9, 2024 17:14
@goetzrrGit goetzrrGit requested a review from a team as a code owner December 9, 2024 17:14
@goetzrrGit goetzrrGit merged commit d44ba82 into develop Dec 9, 2024
1 check passed
@goetzrrGit goetzrrGit deleted the feature/update_rtc_type branch December 9, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants