-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RTC's Type #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
force-pushed
the
feature/update_rtc_type
branch
from
December 2, 2024 21:24
5a83b57
to
2ca47a8
Compare
cohansen
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cartermak
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than version increment.
goetzrrGit
force-pushed
the
feature/update_rtc_type
branch
from
December 6, 2024 18:45
2ca47a8
to
b8fed7c
Compare
cartermak
approved these changes
Dec 6, 2024
* update types to immediate_load, immediate_activate, immediate_command * remove model from immediate_load and imediate_activate
goetzrrGit
force-pushed
the
feature/update_rtc_type
branch
from
December 9, 2024 17:14
b8fed7c
to
7209165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the
immediate_load
andimmediate_activate
types to be specificex.
Also for consistency I added
model
attribute fromimmediateFSWCommands
. I verified with Taifun, Carter, and Mike Schaffer of these changes and they were onboard with it.