-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to clean-up unused AWS EC2 Instances and VPCs #244
base: main
Are you sure you want to change the base?
Conversation
2f8369e
to
348e3c1
Compare
348e3c1
to
c5b9835
Compare
bd378e0
to
5a06340
Compare
@shivakunv It'd be better if the cleanup bot follows the same sequence of operations as laid out in the holodeck delete.go file |
5a06340
to
c4da95a
Compare
followed delete.go sequence:- terminateInstancesInput |
@shivakunv Please amend the commit and retitle the PR as follows
|
Signed-off-by: shiva kumar <[email protected]>
c4da95a
to
d8966a4
Compare
Thanks @tariq1890 for reviewing. passed pipeline:- |
|
||
on: | ||
schedule: | ||
- cron: '0 8 * * *' # Runs daily at 8AM UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdesiniotis @tariq1890
suggestion :-
**- cron: "0 /4 * * "
Since we are deleting only e2e job resources (ci-*), shouldn’t we run this job every 4 hours?
with tag based change, Our cleanup bot will destroy only those resources that are completed.
Instead of running it daily at 8 AM UTC, we should schedule it to run every 4 hours.
No description provided.