-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to clean-up unused AWS EC2 Instances and VPCs #244
Open
shivakunv
wants to merge
1
commit into
main
Choose a base branch
from
awsresourcecleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: Daily AWS Cleanup Bot | ||
|
||
on: | ||
schedule: | ||
- cron: '0 8 * * *' # Runs daily at 8AM UTC | ||
|
||
jobs: | ||
cleanup: | ||
runs-on: linux-amd64-cpu4 | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up AWS CLI | ||
uses: aws-actions/configure-aws-credentials@v4 | ||
with: | ||
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
aws-region: us-west-1 | ||
|
||
- name: Identify resources for deletion | ||
id: identify-resources | ||
run: | | ||
# Find vpcs with names ci* | ||
vpcs=$(aws ec2 describe-vpcs \ | ||
--filters "Name=tag:Name,Values=ci*" \ | ||
--query "Vpcs[].VpcId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
echo "Found VPCs: $vpcs" | ||
echo "AWS_VPC_IDS=$vpcs" >> $GITHUB_ENV | ||
|
||
- name: Clean up VPCs | ||
if: env.AWS_VPC_IDS != '' | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: | | ||
for vpcid in $AWS_VPC_IDS; do | ||
scripts/awscleanup.sh $vpcid | ||
done | ||
|
||
- name: Post cleanup | ||
run: | | ||
echo "Cleanup completed." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,149 @@ | ||
#!/bin/bash | ||
|
||
if [[ $# -ne 1 ]]; then | ||
echo " vpcid required for deletion" | ||
exit 1 | ||
fi | ||
|
||
export vpcid=$1 | ||
|
||
get_tag_value(){ | ||
if [[ $# -ne 2 ]]; then | ||
echo " vpcid and key required to get tag value" | ||
exit 1 | ||
fi | ||
local vpc=$1 | ||
local key=$2 | ||
aws ec2 describe-tags --filters "Name=resource-id,Values=$vpcid" "Name=key,Values=$key" \ | ||
--query "Tags[0].Value" --output text | ||
} | ||
|
||
delete_vpc_resources() { | ||
if [[ $# -ne 1 ]]; then | ||
echo " vpcid required for deletion" | ||
exit 1 | ||
fi | ||
local vpcid=$1 | ||
|
||
echo "Start cleanup of resources in VPC: $vpcid" | ||
|
||
# Delete Instance | ||
instances=$(aws ec2 describe-instances \ | ||
--filters "Name=vpc-id,Values=$vpcid" \ | ||
--query "Reservations[].Instances[].InstanceId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
for instance in $instances; do | ||
aws ec2 terminate-instances --instance-ids "$instance" | ||
done | ||
|
||
# Detach and Delete Security Groups | ||
security_groups=$(aws ec2 describe-security-groups \ | ||
--filters Name=vpc-id,Values=$vpcid \ | ||
--query "SecurityGroups[?GroupName!='default'].GroupId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
for sg in $security_groups; do | ||
enis=$(aws ec2 describe-network-interfaces \ | ||
--filters Name=group-id,Values=$sg \ | ||
--query "NetworkInterfaces[].NetworkInterfaceId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
for eni in $enis; do | ||
aws ec2 modify-network-interface-attribute \ | ||
--network-interface-id "$eni" \ | ||
--groups "$(aws ec2 describe-security-groups \ | ||
--query 'SecurityGroups[?GroupName==`default`].GroupId' \ | ||
--output text)" | ||
done | ||
aws ec2 delete-security-group --group-id "$sg" | ||
done | ||
|
||
# Delete Subnets | ||
subnets=$(aws ec2 describe-subnets \ | ||
--filters Name=vpc-id,Values=$vpcid \ | ||
--query "Subnets[].SubnetId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
for subnet in $subnets; do | ||
aws ec2 delete-subnet --subnet-id "$subnet" | ||
done | ||
|
||
# Delete Route Tables | ||
# 1. Make first rt as Main , as we cannot delete vpcs attached with main | ||
# 2. replace all rt with first rt | ||
# 3. delete rt | ||
# 4. Main table(first_rt) will be deleted once vpc deleted | ||
first_rt="" | ||
route_tables=$(aws ec2 describe-route-tables \ | ||
--filters Name=vpc-id,Values=$vpcid \ | ||
--query "RouteTables[].RouteTableId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
for rt in $route_tables; do | ||
associations=$(aws ec2 describe-route-tables \ | ||
--route-table-ids "$rt" \ | ||
--query "RouteTables[].Associations[].RouteTableAssociationId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
for assoc_id in $associations; do | ||
if [ -z "$first_rt" ]; then | ||
aws ec2 replace-route-table-association --association-id $assoc_id --route-table-id $rt | ||
first_rt=$rt | ||
else | ||
aws ec2 replace-route-table-association --association-id $assoc_id --route-table-id $first_rt | ||
fi | ||
done | ||
aws ec2 delete-route-table --route-table-id "$rt" 2>>/dev/null | ||
done | ||
|
||
# Delete Internet Gateway | ||
internet_gateways=$(aws ec2 describe-internet-gateways \ | ||
--filters Name=attachment.vpc-id,Values=$vpcid \ | ||
--query "InternetGateways[].InternetGatewayId" \ | ||
--output text | tr -d '\r' | tr '\n' ' ') | ||
for igw in $internet_gateways; do | ||
aws ec2 detach-internet-gateway --internet-gateway-id "$igw" --vpc-id "$vpcid" | ||
aws ec2 delete-internet-gateway --internet-gateway-id "$igw" | ||
done | ||
|
||
# Delete vpc | ||
# try 3 times with 30 seconds interval | ||
attempts=0 | ||
echo "All resource Deleted for VPC: $vpcid , now delete vpc" | ||
while [ $attempts -lt 3 ]; do | ||
if aws ec2 delete-vpc --vpc-id $vpcid; then | ||
echo "Successfully deleted VPC: $vpcid" | ||
break | ||
else | ||
attempts=$((attempts + 1)) | ||
if [ $attempts -lt 3 ]; then | ||
echo "Failed to delete VPC: $vpcid. Retrying in 30 seconds..." | ||
sleep 30 | ||
fi | ||
fi | ||
done | ||
if [ $attempts -eq 3 ]; then | ||
echo "Failed to delete VPC: $vpcid after 3 attempts. Continue the loop to delete other vpc" | ||
fi | ||
} | ||
|
||
github_repository=$(get_tag_value $vpcid "GitHubRepository") | ||
run_id=$(get_tag_value $vpcid "GitHubRunId") | ||
job_name=$(get_tag_value $vpcid "GitHubJob") | ||
response=$(curl -s -H "Authorization: Bearer $GITHUB_TOKEN" \ | ||
"https://api.github.com/repos/${github_repository}/actions/runs/${run_id}/jobs") | ||
if [[ -z "$response" || "$response" == "null" ]]; then | ||
exit 0 | ||
fi | ||
|
||
# 1. make sure .jobs exist in response | ||
# e.g. { "message": "Not Found", "documentation_url": "https://docs.github.com/rest", "status": "404" } | ||
# 2. check if all jobs completed | ||
|
||
if ! echo "$response" | jq -e '.jobs != null' >/dev/null 2>&1; then | ||
exit 0 | ||
fi | ||
|
||
is_jobs_not_completed=$(echo "$response" | jq -r ".jobs? // [] | | ||
map(select(.status != \"completed\")) | | ||
length") | ||
|
||
if [[ "$is_jobs_not_completed" -eq 0 ]]; then | ||
echo "Holodeck e2e Job status is not in running stage , Delete the vpc $vpcid and dependent resources" | ||
delete_vpc_resources $vpcid | ||
fi |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdesiniotis @tariq1890
suggestion :-
**- cron: "0 /4 * * "
Since we are deleting only e2e job resources (ci-*), shouldn’t we run this job every 4 hours?
with tag based change, Our cleanup bot will destroy only those resources that are completed.
Instead of running it daily at 8 AM UTC, we should schedule it to run every 4 hours.