Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable tests related to max initcode size #4448

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

agostbiro
Copy link
Member

Re-enable tests related to max initcode size. Fixes NomicFoundation/edr#103

As it turns out, the tests are passing without making a change to REVM, since REVM derives max initcode size from the contract code size and we're setting the contract code size to the maximum when allowUnlimitedContractSize is set to true in the EDR.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

⚠️ No Changeset found

Latest commit: bd0f78a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro self-assigned this Oct 6, 2023
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview Oct 6, 2023 11:24am
hardhat-storybook ✅ Ready (Inspect) Visit Preview Oct 6, 2023 11:24am

@agostbiro agostbiro requested review from fvictorio and Wodann October 6, 2023 11:24
@agostbiro agostbiro linked an issue Oct 6, 2023 that may be closed by this pull request
@agostbiro agostbiro temporarily deployed to edr-release October 6, 2023 11:49 — with GitHub Actions Inactive
@Wodann Wodann merged commit fe2fe05 into rethnet/main Oct 6, 2023
76 of 79 checks passed
@Wodann Wodann deleted the rethnet/max-initcode-size branch October 6, 2023 12:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Re-enable tests related to max initcode size
2 participants