Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #4994

Merged
merged 1 commit into from
Mar 26, 2024
Merged

chore: fix some comments #4994

merged 1 commit into from
Mar 26, 2024

Conversation

suchsoon
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: b72614f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 5:54am

@Wodann
Copy link
Member

Wodann commented Mar 26, 2024

@kanej CI is failing but it's not related to the documentation fixes. I'll leave it to you to decide whether to merge or not.

@kanej kanej merged commit 00cca62 into NomicFoundation:main Mar 26, 2024
95 of 100 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants