Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #4994

Merged
merged 1 commit into from
Mar 26, 2024
Merged

chore: fix some comments #4994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/edr_eth/src/access_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ pub struct AccessListItem {
/// Accessed address
pub address: Address,
/// Accessed storage keys
// In JSON, we have to accept null as well for storage key, but we don't want to to change the
// In JSON, we have to accept null as well for storage key, but we don't want to change the
// type to Option<Vec<_>> as that's invalid in RLP.
#[cfg_attr(
feature = "serde",
Expand Down
2 changes: 1 addition & 1 deletion packages/hardhat-core/test/internal/solidity/resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ describe("Resolver", function () {
);
});

it("Should be local if its first directory exists in the project, even it it doesn't exist", async function () {
it("Should be local if its first directory exists in the project, even if it doesn't exist", async function () {
await expectHardhatErrorAsync(
() => resolver.resolveSourceName("contracts/non-existent.sol"),
ERRORS.RESOLVER.FILE_NOT_FOUND
Expand Down
Loading