Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applayer plugin 5053 v2.10 #11572

Closed

Conversation

catenacyber
Copy link
Contributor

@catenacyber catenacyber commented Jul 29, 2024

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos for some global arrays : run modes and output

Small PR that should be good in itself.

#11373 next round

Based on #11554 with needed rebase to get green CI

Still more work to do : I guess stack allocated arrays are fine, but the global variables cf git grep '\[ALPROTO_MAX' in

  • app-layer-detect-proto.c
  • app-layer-frames.c
  • app-layer-parser.c
  • app-layer-protos.c
  • app-layer.c
    need to be allocated and freed, with taking care of the initialization order, so that we know ALPROTO_MAX final value...

And then take remaining commits out of #11321
And supply an example of an app-layer plugin

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (da1645b) to head (721b442).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11572      +/-   ##
==========================================
- Coverage   82.50%   82.49%   -0.02%     
==========================================
  Files         923      923              
  Lines      248721   248758      +37     
==========================================
+ Hits       205215   205216       +1     
- Misses      43506    43542      +36     
Flag Coverage Δ
fuzzcorpus 60.51% <74.60%> (+<0.01%) ⬆️
livemode 18.81% <79.36%> (+0.17%) ⬆️
pcap 43.56% <87.30%> (-0.51%) ⬇️
suricata-verify 61.76% <87.30%> (-0.02%) ⬇️
unittests 59.07% <60.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21751

@victorjulien victorjulien added this to the 8.0 milestone Jul 30, 2024
This was referenced Jul 31, 2024
@victorjulien
Copy link
Member

Merged in #11595, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants