Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused struct fields #12299

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, just a simple cleanup

Describe changes:

  • src: remove unused struct fields

What about counter_tcp_pseudo_failed ?

Even if they get defined
@victorjulien
Copy link
Member

What about counter_tcp_pseudo_failed ?

Never incremented it seems, so it can be removed.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@2c0d3b8). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12299   +/-   ##
=========================================
  Coverage          ?   83.24%           
=========================================
  Files             ?      912           
  Lines             ?   257622           
  Branches          ?        0           
=========================================
  Hits              ?   214462           
  Misses            ?    43160           
  Partials          ?        0           
Flag Coverage Δ
fuzzcorpus 61.09% <ø> (?)
livemode 19.39% <ø> (?)
pcap 44.44% <ø> (?)
suricata-verify 62.85% <ø> (?)
unittests 59.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber catenacyber requested a review from a team as a code owner December 17, 2024 21:21
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23983

@victorjulien victorjulien self-requested a review December 18, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants