Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused struct fields #12299

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+0 −12
Open

src: remove unused struct fields #12299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d2bac8
src: remove unused struct fields
catenacyber Dec 17, 2024
0f7a0c8
stats: remove unused pseudo_failed stat
catenacyber Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions etc/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6503,9 +6503,6 @@
"pseudo": {
"type": "integer"
},
"pseudo_failed": {
"type": "integer"
},
"reassembly_exception_policy": {
"description":
"How many times reassembly memcap exception policy was applied, and which one",
Expand Down
1 change: 0 additions & 1 deletion src/detect-engine.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3303,7 +3303,6 @@ static TmEcode ThreadCtxDoInit (DetectEngineCtx *de_ctx, DetectEngineThreadCtx *
if (det_ctx->base64_decoded == NULL) {
return TM_ECODE_FAILED;
}
det_ctx->base64_decoded_len_max = de_ctx->base64_decode_max_len;
det_ctx->base64_decoded_len = 0;
}

Expand Down
1 change: 0 additions & 1 deletion src/detect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,6 @@ typedef struct DetectEngineThreadCtx_ {

uint8_t *base64_decoded;
int base64_decoded_len;
int base64_decoded_len_max;

/* counter for the filestore array below -- up here for cache reasons. */
uint16_t filestore_cnt;
Expand Down
1 change: 0 additions & 1 deletion src/source-pcap-file-directory-helper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ typedef struct PcapFileDirectoryVars_
PcapFileFileVars *current_file;
bool should_loop;
bool should_recurse;
uint8_t cur_dir_depth;
time_t delay;
time_t poll_interval;

Expand Down
1 change: 0 additions & 1 deletion src/source-pcap-file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ TmEcode ReceivePcapFileThreadInit(ThreadVars *tv, const void *initdata, void **d
CleanupPcapFileThreadVars(ptv);
SCReturnInt(TM_ECODE_OK);
}
pv->cur_dir_depth = 0;

int should_recurse;
pv->should_recurse = false;
Expand Down
1 change: 0 additions & 1 deletion src/stream-tcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6032,7 +6032,6 @@ TmEcode StreamTcpThreadInit(ThreadVars *tv, void *initdata, void **data)
IsStreamTcpSessionMemcapExceptionPolicyStatsValid);

stt->counter_tcp_pseudo = StatsRegisterCounter("tcp.pseudo", tv);
stt->counter_tcp_pseudo_failed = StatsRegisterCounter("tcp.pseudo_failed", tv);
stt->counter_tcp_invalid_checksum = StatsRegisterCounter("tcp.invalid_checksum", tv);
stt->counter_tcp_midstream_pickups = StatsRegisterCounter("tcp.midstream_pickups", tv);
if (stream_config.midstream) {
Expand Down
2 changes: 0 additions & 2 deletions src/stream-tcp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ typedef struct StreamTcpThread_ {
ExceptionPolicyCounters counter_tcp_ssn_memcap_eps;
/** pseudo packets processed */
uint16_t counter_tcp_pseudo;
/** pseudo packets failed to setup */
uint16_t counter_tcp_pseudo_failed;
/** packets rejected because their csum is invalid */
uint16_t counter_tcp_invalid_checksum;
/** midstream pickups */
Expand Down
1 change: 0 additions & 1 deletion src/util-mpm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ int32_t MpmFactoryRegisterMpmCtxProfile(
else
pitem->next = nitem;

de_ctx->mpm_ctx_factory_container->no_of_items++;
return nitem->id;
}

Expand Down
1 change: 0 additions & 1 deletion src/util-mpm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ typedef struct MpmCtxFactoryItem {

typedef struct MpmCtxFactoryContainer_ {
MpmCtxFactoryItem *items;
int32_t no_of_items;
int32_t max_id;
} MpmCtxFactoryContainer;

Expand Down
Loading