Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed watchdog not logging, increased cycle trigger #23769

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

alexcekay
Copy link
Member

Solved Problem

Looking through some logs, the following problems were found:

  • During MAVLINK logging startup, the logger requires a lot of communication (including ACKs) with the companion. This burst can sometimes cause the logger's main cycle to take more than 3 seconds, triggering the watchdog.
  • If a load measurement is already active, a watchdog trigger will not be detected.
  • The watchdog does not indicate whether it was caused by the logger being in the ready state for too long or by the logger main cycle taking too long.

Solution

  • The cycle timeout has been increased from 3s to 5s.
  • If a load measurement is already active and the watchdog triggers, the cause of the load measurement is overwritten with "Watchdog".
  • The watchdog error log contains the reason for the trigger.

Changelog Entry

For release notes:

Bugfix Fixed watchdog not logging and increased cycle timeout

Test coverage

  • Tested on the bench with a Skynode v5x

@alexcekay alexcekay marked this pull request as ready for review October 3, 2024 09:06
@alexcekay alexcekay requested review from bkueng and niklaut October 3, 2024 09:06
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense

@bkueng bkueng merged commit 936eb89 into main Oct 8, 2024
56 checks passed
@bkueng bkueng deleted the pr-watchdog branch October 8, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants