ci: add test for Ubuntu 22.04 #23869

mrpollo · 2024-10-30T16:32:06Z

Tests the setup script for ubuntu under Ubuntu 22.04 by running a few checks defined in make quick_checks

missing and updated dependencies
fixes python support
updates simulation dependencies
removes jmavsim deps
installs gazebo harmonic by default
setup: install zeromq for ubuntu 24.04
cleans up ubuntu script

mrpollo · 2024-10-30T16:38:55Z

Funny how both are failing.

DronecodeBot · 2024-10-30T17:02:29Z

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-oct-30-2024/42184/1

TannerGilbert · 2024-11-01T07:04:00Z

Funny how both are failing.

Ubuntu 22.04 installation should be fixable using sudo apt-get install -y libunwind-dev similar to #23745 (comment).

hamishwillee · 2024-11-12T23:04:26Z

@mrpollo When this goes in, please direct ping me via email or IM. Since the ubuntu.sh script no longer supporting the older ubuntu versions we need some significant doc updates - for example, older versions should point to the old scripts, but they might point to the main branch versions. For the current version I also need to make it clear this won't work on older Ubuntu and you need to retest.

Maybe you also need marketing around this - it is a pain for developers to be restricted to a particular ubuntu build. Unless they work on windows of course and can use WSL2.

* missing and updated dependencies * setup: install zeromq for ubuntu 24.04 * cleans up ubuntu script

dagar · 2024-11-13T02:54:57Z

As a start let's first keep this super simple to get it going in CI and then iterate. I've stripped it down to Ubuntu 22.04 in CI, installing the arm-none-eabi toolchain from packages (instead of custom /opt). Once that's building cleanly I'll merge and we can then do the rest incrementally.

dagar · 2024-11-13T03:03:01Z

MVP is good to go.

dagar · 2024-11-13T03:10:39Z

Next steps

get this going for 24.04
cleanup simulation
use to build primary px4-dev image

MaEtUgR

I tested on 22.04 and it works even with the packaged ARM GCC. What did we change. I'm almost certain I tested exactly these packages when 22.04 was still new and it failed just like on 20.04. Anyways nice, thank you for the cleanup.

MaEtUgR · 2024-11-13T19:11:20Z

CMakeLists.txt

@@ -408,8 +408,14 @@ include(px4_add_gtest)
 if(BUILD_TESTING)
 	include(gtest)

+	set(TESTFILTERARG "")


@mrpollo May I ask why this was changed? I breaks the unit test filter because it ignores the argument and just always leaves it empty. Can we revert that part?

For some reason something within gtest/ctest was failing when running make tests. The failure was something like "Unknown -R argument."

What we did here is to avoid calling the test without -R when there's no argument to filter through.

Not sure what you mean but this change just breaks the filter. Now when working on any branch from latest main I have to wait for all the tests for every single development iteration 👀 Should I open a pr to revert?

I think I found the problem: #23978 😅

mrpollo · 2024-11-13T20:04:12Z

I tested on 22.04 and it works even with the packaged ARM GCC. What did we change. I'm almost certain I tested exactly these packages when 22.04 was still new and it failed just like on 20.04. Anyways nice, thank you for the cleanup.

There was a missing dependency that made it work, we were running into a linker issue, but @dagar fixed this by finding the missing dependencies

PetervdPerk-NXP · 2024-11-13T20:27:16Z

@dagar @mrpollo

Uhm this changes the default from GCC 9.3.1 to OS installed version, thus Ubuntu 20.04 and Ubuntu 22.04 will use different compilers. Also there were some compiler bugs with the new GCC versions did those got fixed already?

mrpollo · 2024-11-13T20:50:33Z

@PetervdPerk-NXP Going forward, we will only support the last two LTS; this means Ubuntu 22.04 and Ubuntu 24.04 are our only supported versions of Ubuntu now. That said, I would be curious to test adding Ubuntu 18.04 to our CI to see how it deals with the changes.

Regarding the version bump on GCC, we were able to fix the linker issues by installing a few missing dependencies. This PR adds a CI test so we can tell when it breaks.

In #23937 I'm also adding support for Ubuntu 24.04, and moving the CI workflow to containers.

PetervdPerk-NXP · 2024-11-13T21:29:50Z

@mrpollo Well I've got targets now that don't seem to build with GCC 13.2.
Overall I understand we're upgrading the Ubuntu version, but nevertheless the compiler should be decoupled from that.
I.e. first we upgrade the compiler to version XX.XX and then we test that on multiple operating systems / distro's i.e. Ubuntu, Arch Linux, macOS etc.

EDIT it seems the #23937 containers still has GCC 9.3.1 installed but the ubuntu.sh doesn't install GCC 9.3.1.
Thus CI uses GCC 9.3.1 whereas a clean Ubuntu 24.04 install uses GCC 13.2

px4_fmu_v4 doesn't build with GCC 13.2

/home/peter/src/PX4-Autopilot/platforms/common/spi.cpp: In function 'int px4_find_spi_bus(uint32_t)':
/home/peter/src/PX4-Autopilot/platforms/common/spi.cpp:90:59: error: the address of 'px4_spi_buses' will never be NULL [-Werror=address]
   90 |         for (int i = 0; ((px4_spi_bus_t *) px4_spi_buses) != nullptr && i < SPI_BUS_MAX_BUS_ITEMS; ++i) {
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
compilation terminated due to -Wfatal-errors.
cc1plus: all warnings being treated as errors
[536/1335] Building CXX object platforms/common/uORB/CMakeFiles/uORB.dir/uORB.cpp.obj
ninja: build stopped: subcommand failed.
make: *** [Makefile:232: px4_fmu-v4] Error 1
peter@SMW015329:~/src/PX4-Autopilot$

MaEtUgR · 2024-11-19T15:59:35Z

px4_fmu_v4 doesn't build with GCC 13.2

Little did I know my fix would not hold for GCC 13 👀 adb22f1

MaEtUgR · 2024-11-20T14:41:49Z

px4_fmu_v4 doesn't build with GCC 13.2

#23994

MaEtUgR mentioned this pull request Oct 30, 2024

Ubuntu 24.04 Support #23126

Closed

6 tasks

mrpollo force-pushed the mrpollo/ci_ubuntu branch 2 times, most recently from ed52ef7 to 4aa2893 Compare November 7, 2024 19:34

mrpollo changed the title ~~ci: test ubuntu22 and ubuntu24 in ci~~ ci: add test for Ubuntu 22.04 Nov 7, 2024

mrpollo force-pushed the mrpollo/ci_ubuntu branch from 2472252 to c725c4f Compare November 12, 2024 16:54

dagar force-pushed the mrpollo/ci_ubuntu branch 2 times, most recently from 8a1aff7 to 5512233 Compare November 13, 2024 02:45

ci: test ubuntu 22.04 in ci

3c67b01

* missing and updated dependencies * setup: install zeromq for ubuntu 24.04 * cleans up ubuntu script

dagar force-pushed the mrpollo/ci_ubuntu branch from 5512233 to 3c67b01 Compare November 13, 2024 02:53

dagar marked this pull request as ready for review November 13, 2024 03:02

dagar approved these changes Nov 13, 2024

View reviewed changes

dagar merged commit 1e23f25 into main Nov 13, 2024
53 of 54 checks passed

dagar deleted the mrpollo/ci_ubuntu branch November 13, 2024 03:09

MaEtUgR reviewed Nov 13, 2024

View reviewed changes

PetervdPerk-NXP mentioned this pull request Nov 18, 2024

[Bug] PX4 doesn't have a default compiler anymore #23963

Open

MaEtUgR mentioned this pull request Nov 20, 2024

spi: Suppress null pointer warning #23994

Merged

MaEtUgR mentioned this pull request Dec 16, 2024

Add Linux Mint 21.3 support with Gazebo Harmonic #24100

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add test for Ubuntu 22.04 #23869

ci: add test for Ubuntu 22.04 #23869

mrpollo commented Oct 30, 2024 •

edited

Loading

mrpollo commented Oct 30, 2024

DronecodeBot commented Oct 30, 2024

TannerGilbert commented Nov 1, 2024

hamishwillee commented Nov 12, 2024

dagar commented Nov 13, 2024

dagar commented Nov 13, 2024

dagar commented Nov 13, 2024

MaEtUgR left a comment

MaEtUgR Nov 13, 2024 •

edited

Loading

mrpollo Nov 13, 2024

MaEtUgR Nov 19, 2024

MaEtUgR Nov 19, 2024 •

edited

Loading

mrpollo commented Nov 13, 2024

PetervdPerk-NXP commented Nov 13, 2024

mrpollo commented Nov 13, 2024

PetervdPerk-NXP commented Nov 13, 2024 •

edited

Loading

MaEtUgR commented Nov 19, 2024

MaEtUgR commented Nov 20, 2024

ci: add test for Ubuntu 22.04 #23869

ci: add test for Ubuntu 22.04 #23869

Conversation

mrpollo commented Oct 30, 2024 • edited Loading

mrpollo commented Oct 30, 2024

DronecodeBot commented Oct 30, 2024

TannerGilbert commented Nov 1, 2024

hamishwillee commented Nov 12, 2024

dagar commented Nov 13, 2024

dagar commented Nov 13, 2024

dagar commented Nov 13, 2024

MaEtUgR left a comment

Choose a reason for hiding this comment

MaEtUgR Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

mrpollo Nov 13, 2024

Choose a reason for hiding this comment

MaEtUgR Nov 19, 2024

Choose a reason for hiding this comment

MaEtUgR Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

mrpollo commented Nov 13, 2024

PetervdPerk-NXP commented Nov 13, 2024

mrpollo commented Nov 13, 2024

PetervdPerk-NXP commented Nov 13, 2024 • edited Loading

MaEtUgR commented Nov 19, 2024

MaEtUgR commented Nov 20, 2024

mrpollo commented Oct 30, 2024 •

edited

Loading

MaEtUgR Nov 13, 2024 •

edited

Loading

MaEtUgR Nov 19, 2024 •

edited

Loading

PetervdPerk-NXP commented Nov 13, 2024 •

edited

Loading