Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/magnetometer/ak09916: Add support to AK09915 #23909

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

patrickelectric
Copy link
Contributor

@patrickelectric patrickelectric commented Nov 7, 2024

The only difference between the ak09915 and ak09916 is the communication method

Solved Problem

There is no support to AK09915

Solution

  • Add AK09915 support
  • Refactor the code to support AK09915, AK09916, AK09918

Changelog Entry

For release notes:

Feature/Bugfix: Add support to ak09915

Alternatives

Not add support to it ¯\_(ツ)_/¯

Test coverage

Context

AK09915 Datasheet
AK09916 Datasheet

@dagar
Copy link
Member

dagar commented Nov 8, 2024

This seems fine as long as the register maps (or at least the subset we want/need) are literally identical. Did you see the CI failures?
Screenshot 2024-11-07 at 9 32 36 PM

@patrickelectric patrickelectric force-pushed the ak branch 2 times, most recently from 35cd359 to cefb27d Compare November 9, 2024 18:22
The only difference between the ak09915 and ak09916 is the communication method

Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric
Copy link
Contributor Author

@dagar thanks it should be fixed now, there are a couple of CI failures, but they appear to be not from this PR.

@dakejahl dakejahl merged commit bc8f98c into PX4:main Nov 14, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants