VehicleIMU: param change of SENS_IMU_CLPNOTI should have effect without reboot #23912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Nov 10, 2024
| _accel_calibration.ParametersUpdate(); | ||
| _gyro_calibration.ParametersUpdate(); | ||
|
|
||
| const auto accel_calibration_count = _accel_calibration.calibration_count(); |
There was a problem hiding this comment.
Why did this move? It's need to grab the calibration count before the accel calibration parameters are updated, then we know below if it actually changed.
There was a problem hiding this comment.
true, seems I was a bit overeager and didn't take enough time to understand what's going on.
Reverted it.
…metersUpdate() Signed-off-by: Silvan Fuhrer <[email protected]>
sfuhrer
force-pushed
the
pr-vehicle-imu-fix-clipping-noti-param-update-main
branch
from
9be2b9e to
d87f99d
Compare
KonradRudin
approved these changes
Nov 11, 2024
dagar
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
A change of SENS_IMU_CLPNOTI required a reboot. I would expect it to have effect immediately (there is no @reboot required in the meta data).
Solution
Set _notify_clipping on parameter update and not in constructor.
Changelog Entry
For release notes: