uxrce_dds_client - Fix nullptr access in certain cleanup situations #23913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrpollo
pushed a commit
that referenced
this pull request
Nov 12, 2024
…23913) * Only close initialized objects * Added err log in case of no ping * Added err log in case of timesync timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When the uxrce_dds_client is not able to connect it cleans up the current session and retries the connection after a certain time. This works well in most cases, but in certain situations the connection fails even before a session is created. This will cause a nullptr access when trying to clean a session that is not yet created.
Solution
Only clean the session if it has been created.
Changelog Entry
For release notes:
Test coverage