Manual idle current setting #23914
Merged
Manual idle current setting #23914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaut
approved these changes
Nov 11, 2024
|
That is exactly the way I wanted to name the parameter 👍 but yeah param names are limited to 17 chars |
mrpollo
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Added param to overwrite analog idle current measurement * Fixed topic handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Certain ESCs current measurements are inaccurate in case of no load. This is especially important for easier ESCs that only have a CURR wire and only provide the current via an analog current.
Solution
A new parameter
BAT${i}_I_OVERWRITEhas been added that allows to manually set the idle current. The behavior is as follows:Changelog Entry
For release notes:
Test coverage