Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sponsored by Holybro] Add Goermicro/Goertek SPA06 baro driver #23958

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[Sponsored by Holybro] Add Goermicro/Goertek SPA06 baro driver #23958

merged 3 commits into from
Nov 27, 2024

Conversation

julianoes
Copy link
Contributor

This adds a driver for the Goermicro/Goertek SPA06, mostly copying the SPL06 driver.

So far this is only bench tested, over I2C.

FYI @vincentpoont2

@dagar let me know if you want this as a variant of the SPL06 instead and call it SPx06.

@julianoes julianoes requested a review from dagar November 18, 2024 02:10
@github-actions GitHub Actions
Copy link

FLASH Analysis

px4_fmu-v5x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +40  +0.0%     +40    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%      +2  +0.0%      +2    [section .text]
  -0.2%     -40  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +40    TOTAL
px4_fmu-v6x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +48  +0.0%     +48    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%     +10  +0.0%     +10    [section .text]
  -0.1%     -48  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +48    TOTAL

2 similar comments
@github-actions GitHub Actions
Copy link

FLASH Analysis

px4_fmu-v5x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +40  +0.0%     +40    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%      +2  +0.0%      +2    [section .text]
  -0.2%     -40  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +40    TOTAL
px4_fmu-v6x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +48  +0.0%     +48    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%     +10  +0.0%     +10    [section .text]
  -0.1%     -48  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +48    TOTAL

@github-actions GitHub Actions
Copy link

FLASH Analysis

px4_fmu-v5x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +40  +0.0%     +40    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%      +2  +0.0%      +2    [section .text]
  -0.2%     -40  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +40    TOTAL
px4_fmu-v6x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +48  +0.0%     +48    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%     +10  +0.0%     +10    [section .text]
  -0.1%     -48  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +48    TOTAL

dagar
dagar reviewed Nov 19, 2024
View reviewed changes
ROMFS/px4fmu_common/init.d/rc.sensors
if param compare -s SENS_EN_SPA06 1
then
spa06 -X start
spa06 -X -a 0x77 start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why handle 0x77 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied SPL06. Would you do it somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar let me know what you want me to change here, otherwise I'll merge as is.

@dagar
Copy link
Member

dagar commented Nov 19, 2024

This isn't included in any builds?

@julianoes
Copy link
Contributor Author

@dagar it's in the Kakutes, see third commit.

@github-actions GitHub Actions
Copy link

FLASH Analysis

px4_fmu-v5x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +48  +0.0%     +48    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%     +10  +0.0%     +10    [section .text]
  -0.2%     -48  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +48    TOTAL
px4_fmu-v6x 
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +40  +0.0%     +40    .text
    +0.0%     +38  +0.0%     +38    ROMFS/nsh_romfsimg.c
    +0.0%      +2  +0.0%      +2    [section .text]
  -0.1%     -40  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%     +40    TOTAL

@mrpollo
Copy link
Contributor

mrpollo commented Nov 22, 2024

FYI - all tests are passing now

@julianoes julianoes merged commit 95b5859 into main Nov 27, 2024
62 checks passed
@julianoes julianoes deleted the pr-spa06 branch November 27, 2024 23:18
@vincentpoont2
Copy link
Member

@julianoes Can we backport this?

@julianoes julianoes mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar dagar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julianoes @dagar @mrpollo @vincentpoont2