Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission: Replay gimbal cached items before reaching mission waypoint #24085

Merged

Conversation

riccardo-mengoli
Copy link
Contributor

Solved Problem

When flying patterns, photos are sometimes taken while the gimbal is pitching up or down.

Solution

To address this, we orient the gimbal before reaching the mission waypoint, allowing more time to complete the action. Additionally, we verify if the vehicle is climbing to avoid orienting the gimbal while on the ground.

Test coverage

Tested in SITL.

When flying patterns, photos are sometimes taken while the gimbal is pitching up or down. To address this, we orient the gimbal before reaching the mission waypoint, allowing more time to complete the action. Additionally, we verify if the vehicle is climbing to avoid orienting the gimbal while on the ground.
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a follow-up to #23484. There we went a bit too far with replaying the gimbal commands too late, this is now improved with the work here.

Looks reasonable to me and I couldn't break it in SITL testing.

@sfuhrer sfuhrer changed the title Replay gimbal cached items before reaching mission waypoint Mission: Replay gimbal cached items before reaching mission waypoint Dec 10, 2024
@sfuhrer sfuhrer merged commit 09cd429 into PX4:main Dec 10, 2024
53 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants