position control reset tilt limit and hover thrust in non-position mode #24102
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When flying in non position mode, the position control tilt limit is not updated.
Taking off in another mode (in my case offboard attitude control) and changing to a position control mode during flight (in my case pilot take over by RC in position mode) will result in tilt clamping following the takeoff slew rate.
Solution
Update the tilt limit slew rate even if not in position mode ("flag_multicopter_position_control_enabled") as if it was.
With the same reasoning, I have also added a condition to reset the hover thrust as done in position control mode.
Test coverage