Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position control reset tilt limit and hover thrust in non-position mode #24102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NicolasM0
Copy link
Contributor

Solved Problem

When flying in non position mode, the position control tilt limit is not updated.
Taking off in another mode (in my case offboard attitude control) and changing to a position control mode during flight (in my case pilot take over by RC in position mode) will result in tilt clamping following the takeoff slew rate.

Solution

Update the tilt limit slew rate even if not in position mode ("flag_multicopter_position_control_enabled") as if it was.

With the same reasoning, I have also added a condition to reset the hover thrust as done in position control mode.

Test coverage

  • developed and tested on older branch
  • back ported here and test in SITL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant