Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically update ff gain for fw rate control #24120

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Dec 17, 2024

Solved Problem

For fw_rate control, the feedforward term was being computed outside the rate controller.

Solution

This is an aesthetic change that modifies the feedforward gain of the fixed-wing rate controller, rather than adding a separate feedforward computation outside the rate library.

IMHO, this makes it a little bit more clear how the feedforward gain is being computed.
(Saves one vector multiplication and one vector addition :P)

Changelog Entry

For release notes:

Feature/Bugfix Dynamically update feedforward gains, in the fw_rate_control instead of computing feedforward inline.
New parameter: None
Documentation: Dynamically update feedforward gains, in the fw_rate_control.

Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not, yes. Next step would be to move the dynamic pressure scaling to the control allocator (as this changes of the actuator effectiveness)

@Jaeyoung-Lim
Copy link
Member Author

Jaeyoung-Lim commented Dec 17, 2024

@bresch Thanks!

Yes, I am looking into tracking acceleration using iNDI, which would require us to do metric allocation.

@Jaeyoung-Lim Jaeyoung-Lim merged commit fd87cd6 into main Dec 17, 2024
59 of 60 checks passed
@Jaeyoung-Lim Jaeyoung-Lim deleted the pr-fw-rate-feedforward branch December 17, 2024 16:57
mbjd pushed a commit to mbjd/PX4-Autopilot that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants