Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SENS: SF45: Scale the measured distance with pitch and roll #24142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Claudio-Chies
Copy link
Contributor

To prevent oscillations caused by the coupling of pitch and roll, which increase the sensor's measured distance, we account for these effects by introducing scaling based on pitch and roll into the measurements. This adjustment ensures accurate collision prevention.
Issue was solved inside of collision prevention by @mahimayoga in #24107, whereby this implementation is aequivalent.

Pitch

image

Roll

image

Solution

Pitch

image

Roll

image

Test coverage

  • Rough test on Hardware, should be flight tested before Merging.

…e assumption that the measured obstacles are vertical walls,
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about extracting this function to a library so we don't have 2 times the exact same implementation?

@Claudio-Chies
Copy link
Contributor Author

This would be an option, in the long run, i would move away from publishing the obstacle_distance from the sensor, and just publish each measurement with its orientation set as the quaternion, but for this we need a callback based collision prevention map logic, which it is currently not.

If its worth it for the time inbetween i cant say, there you would probably know better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants