Carzyflie: don't compile Navigator ADSB handling #24150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to stage that change in the original change: 839010e
mrpollo
approved these changes
Dec 23, 2024
dagar
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When doing #24131 I forgot to stage the Crazyflie board. It's not out of flash atm but is also flash constrained and very unlikely to be equipped with an ADSB module.
Solution
Remove the by default enabled build flag
CONFIG_NAVIGATOR_ADSBintroduced in the original pull request also on the original Crazyflie target.Test coverage
I built the board locally and it doesn't include the ADSB processing parts in which I had added an
#error.