Use pyproject.toml for setuptools config
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieucan
reviewed
Mar 28, 2024
pyproject.toml
Outdated
| @@ -2,6 +2,34 @@ | |||
| requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]~=6.0"] | |||
| build-backend = "setuptools.build_meta" | |||
|
|
|||
| [project] | |||
| name = "diepvries" | |||
| version = "0.9.2" | |||
There was a problem hiding this comment.
This should be a dynamic attribute, as the version is computed with git tags and setuptools_scm, right?
There was a problem hiding this comment.
Yes, definitely. I also bumped the minimum setuptools and setuptools_scm version as per https://github.com/pypa/setuptools_scm?tab=readme-ov-file#pyprojecttoml-usage
matthieucan
reviewed
Mar 29, 2024
matthieucan
reviewed
Apr 2, 2024
michael-the1
force-pushed
the
use-pyproject
branch
from
7f2edd0 to
a551167
Compare
dlouseiro
approved these changes
Jun 4, 2024
Merged
matthieucan
previously requested changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
pyproject.tomlfor setuptools config