Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _deps to .gitignore #594

Closed
wants to merge 1 commit into from

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Nov 5, 2023

Add _deps to .gitignore.

That folder gets created by CMake I think? Just noticed it getting added when I did cmake . -G "Ninja" && cmake --build .

@GeckoEidechse GeckoEidechse changed the title chore: update gitignore Add _deps to .gitignore Nov 6, 2023
@GeckoEidechse GeckoEidechse marked this pull request as ready for review November 6, 2023 00:13
@@ -373,3 +373,6 @@ MigrationBackup/

# Ionide (cross platform F# VS Code tools) working folder
.ionide/

# CMake deps folder?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do I make the comment say?

@GeckoEidechse GeckoEidechse added the feedback wanted Feedback is wanted whether the changes by this PR are desired label Nov 6, 2023
@Jan200101
Copy link
Contributor

Are you doing in-tree builds?
Those are highly frowned upon and no automated tool will ever even consider doing this.

@GeckoEidechse
Copy link
Member Author

Are you doing in-tree builds? Those are highly frowned upon and no automated tool will ever even consider doing this.

I just ran cmake . -G "Ninja" && cmake --build . as we suggest in our build docs.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 18, 2023
@GeckoEidechse
Copy link
Member Author

@Jan200101 what's the suggested approach to compiling Northstar then so that I can update the build instructions accordingly?

@Jan200101
Copy link
Contributor

cmake -B "build"
cmake --build "build"

@GeckoEidechse
Copy link
Member Author

Superseded by #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Feedback is wanted whether the changes by this PR are desired needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants