Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build instructions and CI for build subfolder #808

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Update build instructions and CI for build subfolder #808

merged 4 commits into from
Sep 3, 2024

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Sep 3, 2024 •
edited
Loading

Set up instructions so that compiling from commandline puts the resulting binaries in /build/game/ to match the folder structure usually generated by Visual Studio.

Supersedes #594

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 3, 2024
@GeckoEidechse GeckoEidechse force-pushed the build/update-ci-and-build-instructions branch from ff4fa43 to ed61651 Compare September 3, 2024 12:31
@GeckoEidechse GeckoEidechse requested a review from F1F7Y September 3, 2024 13:32
@GeckoEidechse GeckoEidechse marked this pull request as ready for review September 3, 2024 13:34
@GeckoEidechse GeckoEidechse changed the title Update build instructions and CI to correct subfolder Update build instructions and CI for build subfolder Sep 3, 2024
@GeckoEidechse GeckoEidechse mentioned this pull request Sep 3, 2024
Closed
F1F7Y
F1F7Y approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

GeckoEidechse
GeckoEidechse commented Sep 3, 2024
View reviewed changes
Copy link
Member Author

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested installing CI build with FlightCore to check for any changes in folder structure and it still worked fine. The release CI part can only be tested when making a release candidate.

@GeckoEidechse GeckoEidechse merged commit f9cb7d1 into main Sep 3, 2024
8 checks passed
@GeckoEidechse GeckoEidechse deleted the build/update-ci-and-build-instructions branch September 3, 2024 13:49
@GeckoEidechse GeckoEidechse mentioned this pull request Sep 3, 2024
Merged
@GeckoEidechse
Copy link
Member Author

Release CI also worked fine for most recent release candidate :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F1F7Y F1F7Y F1F7Y approved these changes

Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeckoEidechse @F1F7Y