Fix character bounds returned by TryMeasureCharacterBounds #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=====================================
Coverage 86% 86%
=====================================
Files 238 238
Lines 15251 15255 +4
Branches 2108 2108
=====================================
+ Hits 13219 13234 +15
+ Misses 1561 1550 -11
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -100,8 +100,15 @@ namespace SixLabors.Fonts; | |||
|
|
|||
| internal FontRectangle BoundingBox(float dpi) | |||
| { | |||
| Vector2 origin = (this.PenLocation + this.Offset) * dpi; | |||
| FontRectangle box = this.Glyph.BoundingBox(this.LayoutMode, this.BoxLocation, dpi); | |||
| // Same logic as in TrueTypeGlyphMetrics.RenderTo | |||
There was a problem hiding this comment.
I thought I'd actually updated this. Obviously not!
JimBobSquarePants
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
refer #397
There was a new test failure in GlyphTests - EmojiWidthIsComputedCorrectlyWithSubstitutionOnZwj
which I fixed by adjusting the test, seems more correct now since it is now the same width with the the substitution.