🐛 Fix completion inside unclosed records #1583
Open
+936
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code used to assume that the first and last characters in the range of a record node are the brackets. No completions would be suggested for key-value pairs when the cursor is at either end of the range, as that is assumed to be outside the brackets. However, this assumption is violated when there is no closing bracket, which is a common occurrence during editing for users who do not rely on their editor to automatically close brackets. This commit fixes the issue by keeping track of the actual range inside the brackets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to assume that the first and last characters in the range of a record node are the brackets. No completions would be suggested for key-value pairs when the cursor is at either end of the range, as that is assumed to be outside the brackets. However, this assumption is violated when there is no closing bracket, which is a common occurrence during editing for users who do not rely on their editor to automatically close brackets. This commit fixes the issue by keeping track of the actual range inside the brackets.