-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#805 #784 As a Subscriber I can settle a negative balance myself #811
Conversation
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
…bscriber-balance-concept
get_stripe_void_subscription_invoices
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 1 alert and fixes 1 when merging 37fdd1c into 9cd5da8 - view on LGTM.com new alerts:
fixed alerts:
|
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 1 alert and fixes 1 when merging 66935df into 9cd5da8 - view on LGTM.com new alerts:
fixed alerts:
|
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 1 alert and fixes 1 when merging d26e57f into 9cd5da8 - view on LGTM.com new alerts:
fixed alerts:
|
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 1 alert and fixes 1 when merging 8d4754a into 9cd5da8 - view on LGTM.com new alerts:
fixed alerts:
|
8d4754a
to
722c51f
Compare
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 1 alert and fixes 1 when merging 9899965 into 9cd5da8 - view on LGTM.com new alerts:
fixed alerts:
|
…bscriber-balance-concept
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 3 alerts and fixes 1 when merging c9ba150 into 6f46253 - view on LGTM.com new alerts:
fixed alerts:
|
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 3 alerts and fixes 1 when merging fa71b8f into 6f46253 - view on LGTM.com new alerts:
fixed alerts:
|
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
This pull request introduces 3 alerts and fixes 1 when merging c39e626 into 6f46253 - view on LGTM.com new alerts:
fixed alerts:
|
🙌 Live preview is here: http://805-subscriber-balance-concept.pcpink.co.uk |
🚀 PR was released in |
This pull request introduces 1 alert and fixes 1 when merging c6207ff into 6f46253 - view on LGTM.com new alerts:
fixed alerts:
|
Ref #805
What's new?
How to test
As a Subscriber, subscribe and find and use test card which fails payments after inital card attachment.Take note of the failed invoice state
open
(As shop admin)As a Subscriber, login to the Subscriber login page
As a Subscriber, locate and visit the "Failed Invoices" page:
(failed invoices page)
6. Obvserve: You are redirected to Stripe invoice payment page 7. Use Stripe test card (e.g. the 4242 ... card) to complete the payment 8. Navigate back to shop (is this automatic?) , TODO: refresh invoices, observe the invoice is changed from status `open` to `paid`.
Details
stripe_invoice
Purpose: To reduce round trip time fetching invoice information from Stripe each time (cache). This is a fast cache (will not be up to date) until refreshed via a get via Stripe api. see detailget_stripe_invoices
) into the tablestripe_invoice
get_stripe_failed_subscription_invoices
, which is fast because it uses the cached tablestripe_invoice
which stores stripe invoices. To determine a failed invoice (from Stripe's perspective is not simple: see detail)balance
@stripe_connect_id_required
, purpose: see comment- does note require stripe connect is activated, only that a stripe connect id exists (and not needed for all pages)/invoices/failed/
to show failed invoices, implemented byget_stripe_failed_subscription_invoices