Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark runner #28

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Benchmark runner #28

merged 3 commits into from
Nov 15, 2023

Conversation

maximusunc
Copy link
Collaborator

Make Benchmarks runnable as a pypi package so it can be incorporated into the Translator-wide testing framework/Test Harness.

@maximusunc maximusunc mentioned this pull request Nov 13, 2023
Closed
andrewsu
andrewsu approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@andrewsu andrewsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Just one more comment. It looks like the python package does not allow the user to specify that the output TRAPI files be saved. I think that could be a useful feature. Not essential, so could absolutely be a follow up issue and PR...

@maximusunc maximusunc mentioned this pull request Nov 14, 2023
Open
@maximusunc
Copy link
Collaborator Author

maximusunc commented Nov 15, 2023 •
edited
Loading

Added a new issue to track the request above (#30).

@maximusunc maximusunc merged commit 27a3834 into main Nov 15, 2023
@maximusunc maximusunc deleted the benchmark_runner branch November 15, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsu andrewsu andrewsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximusunc @andrewsu