Arm firmware implementation #407
Conversation
There was a problem hiding this comment.
The bin folder and the obj folder should not be included in the repo. Also the SerialCom.sln file as well as all the .resx files seem to be specific to Visual Studio and can be removed as well, unless I'm mistaken. I believe you also don't need the Properties folder, but I'll need to look more in depth to be sure.
| if(ang == 0) { | ||
| } | ||
|
|
| bool a5FinishFlag = false; | ||
| bool a6FinishFlag = false; | ||
|
|
||
| while (!completeFlag) { |
There was a problem hiding this comment.
Be consistent with the indentation in this while loop so that the code is easier to read
| } | ||
| } | ||
|
|
||
| void a6LimTrigger() { |
There was a problem hiding this comment.
This applies to the other functions above as well but I think the code could benefit from refactoring.
With the LimTrigger functions for instance, the only difference between a5LimTrigger and a6LimTrigger is that one operates on a5 and the other operates on a6. It would be cleaner if there was a generic LimTrigger function that can accept a5 or a6 or whatever as a parameter, and then you wouldn't be repeating so much code.
Co-authored-by: Ihsan Olawale <[email protected]>
Co-authored-by: Ihsan Olawale <[email protected]>
Co-authored-by: Ihsan Olawale <[email protected]>
Co-authored-by: Ihsan Olawale <[email protected]>
Co-authored-by: Ihsan Olawale <[email protected]>
Co-authored-by: Ihsan Olawale <[email protected]>
…ored code (deleted 400 lines or something crazy). Check out how simple the home function is now! So happy with this. Code compiles, will test in coming weeks
|
|
||
| // stepper motor objects for AccelStepper library | ||
| AccelStepper steppers[6]; | ||
|
|
There was a problem hiding this comment.
will delete extra spaces next push
…ould be great for you to have a read over and point out glaring issues
Please fill out the following before requesting review on this PR
Description
ArmSketchRev3: Main Arm testing firmware for teensy board. Allows homing of arm with limit switches, and incremental and absolute motion of individual axes.
SerialCom1: C# Windows form UI for communication with ArmSketchRev3. Allows user to input angles into a terminal and home the arm.
Testing Done
All code has been tested on arm. Under constant construction so will be more PR's in near future.
Resolved Issues
NA
Review Checklist
(Please check every item to indicate your code complies with it (by changing
[ ]->[x]). This will hopefully save both you and the reviewer(s) a lot of time!)It is the reviewers responsibility to also make sure every item here has been covered
.cppand.hfile should have a comment at the start of it. See files insrc/sample_packagefor examples..hfile) should have a javadoc style comment at the start of them. For examples, see the classes defined insrc/sample_packageTODO(or similar) statements should either be completed or associated with a github issueFeel free to make additions of things that we should be checking to this file if you think there's something missing!!!!