-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023arm #441
Open
Roozki
wants to merge
68
commits into
master
Choose a base branch
from
2023arm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via apt, add qt4 repo
…ones. repo compiles, but does not pass tests
…n. SerialStream is no longer, we are using SerialPort instead. Changed up the arm_driver code to use SerialPort instead of SerialStream
… get new hardware Other than gps, full repo working on 20.04 and Noetic arcu detection tested, working added init_camera package, it holds a simple camera publishing script. Usefull when testing without the RealSense cams
for the realsense cams, cameras were not initilizing without this pkg
…rocontroller was connected what i did: 1. added subscriber to read from /joy 2. parsed that data into buttons[] and axes[] 3. multiplied the -1,1 range of /joy axes so the interface would display the same info, this leads to unneccessary floating point math that i plan to edit later
- worked with simpler testting program, im guessing some serial stuff is getting messed up
will have to remove/disable remaining serial communication functions in firmware
…uous angle feedback
…Driver communictation working, teensy commmunication not working
…ome function, all_controller not parsing properly
…as procontroller now
…th together, 1 and 4 are also smooth together. 1,2,3,4 alltogether are pretty smooth, but a little rough
…nto AllController
should have working controller updated into Moveit stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Give a high-level description of the changes in this PR
Testing Done
Outline any testing that was done for these changes. This could be unit tests, integration tests, etc.
Resolved Issues
Link any issues that this PR resolved. Eg
resolves #1, #2, and #5
(note that they MUST be specified like this so Github can automatically close them then this PR merges)Review Checklist
(Please check every item to indicate your code complies with it (by changing
[ ]
->[x]
). This will hopefully save both you and the reviewer(s) a lot of time!)It is the reviewers responsibility to also make sure every item here has been covered
.cpp
and.h
file should have a comment at the start of it. See files insrc/sample_package
for examples..h
file) should have a javadoc style comment at the start of them. For examples, see the classes defined insrc/sample_package
TODO
(or similar) statements should either be completed or associated with a github issueFeel free to make additions of things that we should be checking to this file if you think there's something missing!!!!