Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-catalog): remove usage of catalog #43

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

matanmichaely
Copy link

@matanmichaely matanmichaely commented Aug 20, 2024

Context

In current implementation in order to convert dbt models to lookml entities we are using both manifest.json and catalog.json .
The convert operation can be executed only by using the manifest.json file , (run execution update the model's metadata file) .
The catalog.json file was required because in Yoda we don't have a mechanism which verifies execution of run before PR submission .
We are planning to add such mechanism and remove the usage of catalog.

Changes

  • Remove usage of catalog
  • Use dbt models' column types directly from the given manifest file.
  • Update spark types dictionary with data types which were missing.
  • Update manifest.json for each model (under nodes) changed column's attribute type -> data_type
  • Update looker views under expected_lookml folder because order of dimensions and measures was changed , only order was changed

@matanmichaely matanmichaely marked this pull request as ready for review August 20, 2024 13:56
@matanmichaely matanmichaely merged commit 19ac7c4 into main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants