feat(remove-catalog): remove usage of catalog #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In current implementation in order to convert dbt models to lookml entities we are using both
manifest.json
andcatalog.json
.The convert operation can be executed only by using the
manifest.json
file , (run
execution update the model's metadata file) .The
catalog.json
file was required because in Yoda we don't have a mechanism which verifies execution ofrun
before PR submission .We are planning to add such mechanism and remove the usage of catalog.
Changes
manifest.json
for each model (under nodes) changed column's attributetype -> data_type
expected_lookml
folder because order of dimensions and measures was changed , only order was changed