Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-catalog): remove usage of catalog #43

Merged
merged 4 commits into from
Sep 3, 2024
Merged

feat(remove-catalog): remove usage of catalog #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6db711
feat(remove-catalog): remove usage of catalog
matanmichaely Aug 20, 2024
27b658e
feat(remove-catalog): update spark types in dictionary
matanmichaely Aug 20, 2024
8e0fa3a
fix(type): revert change from data_type to type in column attribute
matanmichaely Sep 2, 2024
9d5a1d8
fix(tests): update manifest and generated views
matanmichaely Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 81 additions & 81 deletions tests/resources/expected_lookml/views/yoda_e2e_bi___loyalty__fact_purchases.view.lkml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
view: yoda_e2e_bi___loyalty__fact_purchases {
sql_table_name: public_yoda_e2e_bi.loyalty_fact_purchases ;;

dimension_group: purchase_created_at {
dimension_group: dwh_updated_at {
type: time
sql: ${TABLE}.purchase_created_at ;;
sql: ${TABLE}.dwh_updated_at ;;
description: "TODO: Update Column {col_name} Information"
datatype: timestamp
timeframes: [
Expand All @@ -18,9 +18,9 @@ view: yoda_e2e_bi___loyalty__fact_purchases {
]
}

dimension_group: purchase_updated_at {
dimension_group: purchase_created_at {
type: time
sql: ${TABLE}.purchase_updated_at ;;
sql: ${TABLE}.purchase_created_at ;;
description: "TODO: Update Column {col_name} Information"
datatype: timestamp
timeframes: [
Expand Down Expand Up @@ -52,9 +52,9 @@ view: yoda_e2e_bi___loyalty__fact_purchases {
]
}

dimension_group: dwh_updated_at {
dimension_group: purchase_updated_at {
type: time
sql: ${TABLE}.dwh_updated_at ;;
sql: ${TABLE}.purchase_updated_at ;;
description: "TODO: Update Column {col_name} Information"
datatype: timestamp
timeframes: [
Expand All @@ -69,123 +69,135 @@ view: yoda_e2e_bi___loyalty__fact_purchases {
]
}

dimension: purchase_id {
type: number
sql: ${TABLE}.purchase_id ;;
dimension: app_key {
type: string
sql: ${TABLE}.app_key ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: is_before_swell_acquisition {
type: number
sql: ${TABLE}.is_before_swell_acquisition ;;
dimension: billing_city {
type: string
sql: ${TABLE}.billing_city ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: is_applied_to_campaigns {
dimension: browser_country_code {
type: string
sql: ${TABLE}.browser_country_code ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: customer_id__swell_customers {
type: number
sql: ${TABLE}.is_applied_to_campaigns ;;
sql: ${TABLE}.customer_id__swell_customers ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: is_fraud_review {
dimension: customer_ip_address {
type: string
sql: ${TABLE}.customer_ip_address ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: discount_cents_in_original_currency {
type: number
sql: ${TABLE}.is_fraud_review ;;
sql: ${TABLE}.discount_cents_in_original_currency ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: is_swell_user {
dimension: is_active_store {
type: number
sql: ${TABLE}.is_swell_user ;;
sql: ${TABLE}.is_active_store ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: is_move_merchant_to_new_tier {
dimension: is_applied_to_campaigns {
type: number
sql: ${TABLE}.is_move_merchant_to_new_tier ;;
sql: ${TABLE}.is_applied_to_campaigns ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: purchase_value_cents_in_original_currency {
dimension: is_before_swell_acquisition {
type: number
sql: ${TABLE}.purchase_value_cents_in_original_currency ;;
sql: ${TABLE}.is_before_swell_acquisition ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: purchase_currency {
type: string
sql: ${TABLE}.purchase_currency ;;
dimension: is_fraud_review {
type: number
sql: ${TABLE}.is_fraud_review ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: discount_cents_in_original_currency {
dimension: is_move_merchant_to_new_tier {
type: number
sql: ${TABLE}.discount_cents_in_original_currency ;;
sql: ${TABLE}.is_move_merchant_to_new_tier ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: billing_city {
type: string
sql: ${TABLE}.billing_city ;;
dimension: is_swell_user {
type: number
sql: ${TABLE}.is_swell_user ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: shipping_country_code {
type: string
sql: ${TABLE}.shipping_country_code ;;
dimension: is_test_store {
type: number
sql: ${TABLE}.is_test_store ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: shipping_city {
type: string
sql: ${TABLE}.shipping_city ;;
dimension: merchant_id__dim_stores {
type: number
sql: ${TABLE}.merchant_id__dim_stores ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: customer_ip_address {
dimension: order_id__fact_orders {
type: string
sql: ${TABLE}.customer_ip_address ;;
sql: ${TABLE}.order_id__fact_orders ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: browser_country_code {
type: string
sql: ${TABLE}.browser_country_code ;;
dimension: organization_id {
type: number
sql: ${TABLE}.organization_id ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: store_address {
dimension: platform_name {
type: string
sql: ${TABLE}.store_address ;;
sql: ${TABLE}.platform_name ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: store_city {
dimension: purchase_currency {
type: string
sql: ${TABLE}.store_city ;;
sql: ${TABLE}.purchase_currency ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: store_state {
type: string
sql: ${TABLE}.store_state ;;
dimension: purchase_id {
type: number
sql: ${TABLE}.purchase_id ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: referral_discount_code_id__swell_referral_discount_code {
dimension: purchase_value_cents_in_original_currency {
type: number
sql: ${TABLE}.referral_discount_code_id__swell_referral_discount_code ;;
sql: ${TABLE}.purchase_value_cents_in_original_currency ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: merchant_id__dim_stores {
dimension: redemption_code_id__swell_redemption_code {
type: number
sql: ${TABLE}.merchant_id__dim_stores ;;
sql: ${TABLE}.redemption_code_id__swell_redemption_code ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: customer_id__swell_customers {
dimension: referral_discount_code_id__swell_referral_discount_code {
type: number
sql: ${TABLE}.customer_id__swell_customers ;;
sql: ${TABLE}.referral_discount_code_id__swell_referral_discount_code ;;
description: "TODO: Update Column {col_name} Information"
}

Expand All @@ -195,27 +207,27 @@ view: yoda_e2e_bi___loyalty__fact_purchases {
description: "TODO: Update Column {col_name} Information"
}

dimension: user_agent_id__swell_user_agent {
type: number
sql: ${TABLE}.user_agent_id__swell_user_agent ;;
dimension: shipping_city {
type: string
sql: ${TABLE}.shipping_city ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: redemption_code_id__swell_redemption_code {
type: number
sql: ${TABLE}.redemption_code_id__swell_redemption_code ;;
dimension: shipping_country_code {
type: string
sql: ${TABLE}.shipping_country_code ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: order_id__fact_orders {
dimension: store_address {
type: string
sql: ${TABLE}.order_id__fact_orders ;;
sql: ${TABLE}.store_address ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: app_key {
dimension: store_city {
type: string
sql: ${TABLE}.app_key ;;
sql: ${TABLE}.store_city ;;
description: "TODO: Update Column {col_name} Information"
}

Expand All @@ -231,27 +243,15 @@ view: yoda_e2e_bi___loyalty__fact_purchases {
description: "TODO: Update Column {col_name} Information"
}

dimension: organization_id {
type: number
sql: ${TABLE}.organization_id ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: is_test_store {
type: number
sql: ${TABLE}.is_test_store ;;
dimension: store_state {
type: string
sql: ${TABLE}.store_state ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: is_active_store {
dimension: user_agent_id__swell_user_agent {
type: number
sql: ${TABLE}.is_active_store ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: platform_name {
type: string
sql: ${TABLE}.platform_name ;;
sql: ${TABLE}.user_agent_id__swell_user_agent ;;
description: "TODO: Update Column {col_name} Information"
}

Expand Down
36 changes: 18 additions & 18 deletions tests/resources/expected_lookml/views/yoda_e2e_infra__reporting_example.view.lkml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
view: yoda_e2e_infra__reporting_example {
sql_table_name: public_yoda_e2e_infra.reporting_example ;;

dimension: kubecost_data_container {
type: string
sql: ${TABLE}.kubecost_data_container ;;
dimension: average_of_cpu_efficiency {
type: number
sql: ${TABLE}.average_of_cpu_efficiency ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: kubecost_data_product_line {
type: string
sql: ${TABLE}.kubecost_data_product_line ;;
dimension: average_of_ram_efficiency {
type: number
sql: ${TABLE}.average_of_ram_efficiency ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: kubecost_data_team {
dimension: kubecost_data_container {
type: string
sql: ${TABLE}.kubecost_data_team ;;
sql: ${TABLE}.kubecost_data_container ;;
description: "TODO: Update Column {col_name} Information"
}

Expand All @@ -25,27 +25,27 @@ view: yoda_e2e_infra__reporting_example {
description: "TODO: Update Column {col_name} Information"
}

dimension: average_of_ram_efficiency {
type: number
sql: ${TABLE}.average_of_ram_efficiency ;;
dimension: kubecost_data_product_line {
type: string
sql: ${TABLE}.kubecost_data_product_line ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: average_of_cpu_efficiency {
type: number
sql: ${TABLE}.average_of_cpu_efficiency ;;
dimension: kubecost_data_team {
type: string
sql: ${TABLE}.kubecost_data_team ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: total_cost {
dimension: savings_opportunities {
type: number
sql: ${TABLE}.total_cost ;;
sql: ${TABLE}.savings_opportunities ;;
description: "TODO: Update Column {col_name} Information"
}

dimension: savings_opportunities {
dimension: total_cost {
type: number
sql: ${TABLE}.savings_opportunities ;;
sql: ${TABLE}.total_cost ;;
description: "TODO: Update Column {col_name} Information"
}

Expand Down
Loading
Loading