Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSF throws warnings regularly with ODD #3738

Open
andiwand opened this issue Oct 16, 2024 · 3 comments
Open

GSF throws warnings regularly with ODD #3738

andiwand opened this issue Oct 16, 2024 · 3 comments

Comments

@andiwand
Copy link
Contributor

I see the following warning quite often with the GSF and the ODD:

Encountered 47 cases where x/X0 exceeds the range of the Bethe-Heitler-Approximation. The maximum x/X0 encountered was 2.0238. Enable DEBUG output for more information.

To avoid CI failures I had to reduce the number of events we run in test_examples with #3733.

@benjaminhuth mentioned that we may have to re-parametrize the energy loss polynom or to understand why we encounter such thick material in the ODD.

kodiakhq bot pushed a commit that referenced this issue Oct 18, 2024
This adds an option that should disable the warnings appearing in the GSF in a meaningful way...

Worksaround but does not solve #3738
@andiwand
Copy link
Contributor Author

#3739 improves the situation by clamping X/X0 to the valid range of the approximation.

Still open

  • investigate where and why we exceed the valid input range of the approximation
  • define a procedure to train/retrain the approximation
  • retrain the approximation for the ODD if necessary

@AJPfleger
Copy link
Contributor

devmeeting: The problem is not ODD specific and can also be seen in ATHENA on the ITk.

Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this issue Nov 13, 2024
This adds an option that should disable the warnings appearing in the GSF in a meaningful way...

Worksaround but does not solve acts-project#3738
Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants