Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Physmon for KF and GSF refitting #3733

Merged
merged 12 commits into from
Oct 16, 2024

Conversation

andiwand
Copy link
Contributor

Adds KF and GSF refitting to physmon. This allows us to also track physics related changes with fitters and direct navigation.

In principle we could monitor the output by comparing it to the normal navigation ones but for now I would opt for creating additional reference files. Later we can converge on the outputs if we want to.

@andiwand andiwand added this to the next milestone Oct 15, 2024
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module labels Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

📊: Physics performance monitoring for c51f9ca

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review October 15, 2024 17:23
Copy link

@kodiakhq kodiakhq bot merged commit ff6d195 into acts-project:main Oct 16, 2024
42 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Oct 16, 2024

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 16, 2024
@andiwand andiwand deleted the physmon-refitting branch October 16, 2024 11:09
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 17, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
Adds KF and GSF refitting to physmon. This allows us to also track physics related changes with fitters and direct navigation.

In principle we could monitor the output by comparing it to the normal navigation ones but for now I would opt for creating additional reference files. Later we can converge on the outputs if we want to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants