-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Physmon for KF and GSF refitting #3733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Component - Examples
Affects the Examples module
labels
Oct 15, 2024
AJPfleger
reviewed
Oct 16, 2024
AJPfleger
approved these changes
Oct 16, 2024
Quality Gate passedIssues Measures |
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Oct 16, 2024
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
Adds KF and GSF refitting to physmon. This allows us to also track physics related changes with fitters and direct navigation. In principle we could monitor the output by comparing it to the normal navigation ones but for now I would opt for creating additional reference files. Later we can converge on the outputs if we want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Changes Performance
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds KF and GSF refitting to physmon. This allows us to also track physics related changes with fitters and direct navigation.
In principle we could monitor the output by comparing it to the normal navigation ones but for now I would opt for creating additional reference files. Later we can converge on the outputs if we want to.