Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make it possible to turn off warnings in GSF #3739

Merged
merged 11 commits into from
Oct 18, 2024
Merged

feat: Make it possible to turn off warnings in GSF #3739

merged 11 commits into from
Oct 18, 2024

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Oct 16, 2024 •
edited
Loading

This adds an option that should disable the warnings appearing in the GSF in a meaningful way...

Worksaround but does not solve #3738

@benjaminhuth benjaminhuth added this to the next milestone Oct 16, 2024
@benjaminhuth benjaminhuth requested a review from andiwand October 16, 2024 10:13
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting labels Oct 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

📊: Physics performance monitoring for f18e6b1

Full contents

physmon summary

andiwand
andiwand previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense from my side. I think this is best we can do for now 👍

@benjaminhuth benjaminhuth marked this pull request as ready for review October 16, 2024 11:33
@benjaminhuth benjaminhuth requested a review from andiwand October 17, 2024 07:00
@andiwand andiwand changed the title feat: Make it possible to turn of warnings in GSF feat: Make it possible to turn off warnings in GSF Oct 17, 2024
@paulgessinger
Copy link
Member

paulgessinger commented Oct 17, 2024 •
edited
Loading

There seems to be a compilation failure, but it might be transient.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 41066dc into acts-project:main Oct 18, 2024
42 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [41066dc]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 18, 2024
@andiwand andiwand mentioned this pull request Oct 19, 2024
Open
@paulgessinger paulgessinger modified the milestones: next, v37.2.0 Oct 24, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@benjaminhuth @Rosie-Hasan
feat: Make it possible to turn off warnings in GSF (acts-project#3739)
053c8b1 
This adds an option that should disable the warnings appearing in the GSF in a meaningful way...

Worksaround but does not solve acts-project#3738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger left review comments

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting
Projects
None yet
Milestone
v37.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminhuth @paulgessinger @acts-project-service @andiwand