-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrades ES to 7.13.3 #1386
Conversation
Signed-off-by: verdan <[email protected]>
Signed-off-by: verdan <[email protected]>
that's cool. I recall the mapping field is no longer needed in 7.x. Does the change intent to support both ES 6.x and 7.x? |
Yes, the intent is to support both 6.x and 7.x. |
we still have some mapping definitions in amundsen common that need to be refactored |
Signed-off-by: verdan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I still run into this issue, while running sample dataloader |
the AWS ECS Install files did not get the ES upgrade in this PR, but later in (still unmerged) PR; https://github.com/amundsen-io/amundsen/pull/1640/files |
I would disregard #1640 and go straight to es 8.0.0 which is used here https://github.com/amundsen-io/amundsen/blob/main/docker-amundsen.yml |
* Upgrades ES to 7.13.3 Signed-off-by: verdan <[email protected]> * typo Signed-off-by: verdan <[email protected]> * Fixes the test cases, and code review Signed-off-by: verdan <[email protected]>
* Upgrades ES to 7.13.3 Signed-off-by: verdan <[email protected]> * typo Signed-off-by: verdan <[email protected]> * Fixes the test cases, and code review Signed-off-by: verdan <[email protected]>
Signed-off-by: verdan [email protected]
Summary of Changes
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.