Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades ES to 7.13.3 #1386

Merged
merged 3 commits into from
Jul 30, 2021
Merged

chore: Upgrades ES to 7.13.3 #1386

merged 3 commits into from
Jul 30, 2021

Conversation

verdan
Copy link
Member

@verdan verdan commented Jul 26, 2021

Signed-off-by: verdan [email protected]

Summary of Changes

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@boring-cyborg boring-cyborg bot added area:databuilder From databuilder folder area:all Related to all the project area:search From the search folder category:proxy labels Jul 26, 2021
@verdan verdan requested a review from mgorsk1 July 26, 2021 14:39
Signed-off-by: verdan <[email protected]>
@feng-tao
Copy link
Member

that's cool. I recall the mapping field is no longer needed in 7.x. Does the change intent to support both ES 6.x and 7.x?

@verdan
Copy link
Member Author

verdan commented Jul 27, 2021

that's cool. I recall the mapping field is no longer needed in 7.x. Does the change intent to support both ES 6.x and 7.x?

Yes, the intent is to support both 6.x and 7.x.

@mgorsk1
Copy link
Contributor

mgorsk1 commented Jul 27, 2021

we still have some mapping definitions in amundsen common that need to be refactored

@verdan verdan marked this pull request as ready for review July 27, 2021 13:01
@verdan verdan requested a review from a team as a code owner July 27, 2021 13:01
@verdan verdan requested review from mgorsk1 and feng-tao July 27, 2021 13:01
Copy link
Contributor

@mgorsk1 mgorsk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@verdan verdan merged commit 217d211 into main Jul 30, 2021
@verdan verdan deleted the vm/upgrade-es-to-7x branch July 30, 2021 11:03
@rr-sucheth-shivakumar
Copy link

rr-sucheth-shivakumar commented Jul 30, 2021

I still run into this issue, while running sample dataloader
elasticsearch.exceptions.RequestError: RequestError(400, 'mapper_parsing_exception', 'Root mapping definition has unsupported parameters: [table : {properties={schema={analyzer=simple, type=text, fields={raw={type=keyword}}}, cluster={analyzer=simple, type=text, fields={raw={type=keyword}}}, description={analyzer=simple, type=text}, display_name={type=keyword}, column_descriptions={analyzer=simple, type=text}, programmatic_descriptions={analyzer=simple, type=text}, tags={type=keyword}, badges={type=keyword}, database={analyzer=simple, type=text, fields={raw={type=keyword}}}, total_usage={type=long}, name={analyzer=simple, type=text, fields={raw={type=keyword}}}, last_updated_timestamp={format=epoch_second, type=date}, unique_usage={type=long}, column_names={analyzer=simple, type=text, fields={raw={normalizer=column_names_normalizer, type=keyword}}}, key={type=keyword}}}]')

@lhoss
Copy link

lhoss commented Mar 31, 2022

the AWS ECS Install files did not get the ES upgrade in this PR, but later in (still unmerged) PR; https://github.com/amundsen-io/amundsen/pull/1640/files

@mgorsk1
Copy link
Contributor

mgorsk1 commented Mar 31, 2022

I would disregard #1640 and go straight to es 8.0.0 which is used here https://github.com/amundsen-io/amundsen/blob/main/docker-amundsen.yml

zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
* Upgrades ES to 7.13.3

Signed-off-by: verdan <[email protected]>

* typo

Signed-off-by: verdan <[email protected]>

* Fixes the test cases, and code review

Signed-off-by: verdan <[email protected]>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
* Upgrades ES to 7.13.3

Signed-off-by: verdan <[email protected]>

* typo

Signed-off-by: verdan <[email protected]>

* Fixes the test cases, and code review

Signed-off-by: verdan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:all Related to all the project area:databuilder From databuilder folder area:search From the search folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants