Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new solution and project files for .NET standard #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andywcoder
Copy link

@andywcoder andywcoder commented May 30, 2020

The existing solution and project files have been left untouched. The new SDK style project files only target .NET standard 2.0. They could also target .NET 2.0, but I didn't want to mess around with that version.

I added .NET standard support only for the projects that supported that without any code changes.

The binaries are still stored in the release folder (in a sub-folder), so it would be quite easy to create nuget packages that target .NET 2.0 and .NET standard 2.0 at the same time.

@hansmbakker
Copy link

I suggest to put the content of AssemblyInfo.cs in the *.csproj files and remove the AssemblyInfo.cs files and the compile remove statements.

For the rest, good that you're doing this!

@andrewkirillov please note that somebody else already put a netstandard copy of your library on NuGet which doesn't work properly, I would like it more to have an official one :)

@andywcoder
Copy link
Author

I'm glad you like it. I left the AssemblyInfo.cs files in there on purpose, so that it's still possible to build the original solution and project files (since they need the AssemblyInfo.cs files).

@hansmbakker
Copy link

In that case you can also use the <GenerateAssemblyInfo>false</GenerateAssemblyInfo> element to fix it.

@hansmbakker
Copy link

@Andy9FromSpace I just saw that @andrewkirillov wrote on the forum:

As the project is no longer maintained, the registration of new forum users was disabled

source: http://www.aforgenet.com/forum/viewtopic.php?f=2&t=4476

I'm afraid that it means that the chances that your PR will be accepted are small :(

@andrewkirillov could you please review this PR and update the nuget packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants