Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #62

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Fix compiler warnings #62

wants to merge 33 commits into from

Conversation

drroe
Copy link
Contributor

@drroe drroe commented Nov 24, 2021

This fixes several warnings that would be generated by GNU compilers with -Wall, mostly signed/unsigned comparisons, adding preprocessor guards for OpenMP #pragmas, and initializing uninitialized variables.

@andysim There is one change I would like you to review. In helpme.h line 1603 there was an unused variable that I commented out:

            auto &mySplineList = splinesPerThread_[threadID];
            //const auto &gridIteratorC = threadedGridIteratorC_[threadID]; FIXME currently unused
            mySplineList.clear();

There is a class variable gridIteratorC_ that is being used instead below this. Should gridIteratorC_ be getting assigned from threadedGridIteratorC_? Commenting it out doesn't seem to break anything but it looks like it might actually have a purpose so I wanted to check with you.

@drroe
Copy link
Contributor Author

drroe commented Nov 24, 2021

@andysim OK, I'm not as experienced in the code coverage area - seems like it's failing because I added an extra check to make sure the signed vars aren't negative before casting to unsigned. Do I need to now add new tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant