Fix Docker README.md #4160
Merged
Fix Docker README.md #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
reviewed
Dec 25, 2023
| @@ -118,7 +118,7 @@ docker run -it --rm \ | |||
| --network "bk_network" \ | |||
| --env BK_zkServers=test_zookeeper:2181 \ | |||
| apache/bookkeeper \ | |||
| bookkeeper shell metaformat | |||
| /opt/bookkeeper/bin/bookkeeper shell metaformat | |||
There was a problem hiding this comment.
Do we need the /opt/bookkeeper prefix? @zymap Please help take a look, thanks.
There was a problem hiding this comment.
Line 59 in 1e3efa1
mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/
Line 68 in 1e3efa1
bookkeeper/docker/scripts/entrypoint.sh
Line 58 in 1e3efa1
zwOvO
approved these changes
Dec 27, 2023
| @@ -118,7 +118,7 @@ docker run -it --rm \ | |||
| --network "bk_network" \ | |||
| --env BK_zkServers=test_zookeeper:2181 \ | |||
| apache/bookkeeper \ | |||
| bookkeeper shell metaformat | |||
| /opt/bookkeeper/bin/bookkeeper shell metaformat | |||
There was a problem hiding this comment.
Line 59 in 1e3efa1
mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/
Line 68 in 1e3efa1
bookkeeper/docker/scripts/entrypoint.sh
Line 58 in 1e3efa1
zymap
approved these changes
Dec 27, 2023
hangc0276
approved these changes
Jan 8, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Descriptions of the changes in this PR: Fix Docker README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fix Docker README.md