Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker README.md #4160

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix Docker README.md #4160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ docker run -it --rm \
--network "bk_network" \
--env BK_zkServers=test_zookeeper:2181 \
apache/bookkeeper \
bookkeeper shell metaformat
/opt/bookkeeper/bin/bookkeeper shell metaformat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the /opt/bookkeeper prefix? @zymap Please help take a look, thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bookkeeper/docker/Dockerfile

Line 59 in 1e3efa1

&& mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/ \

mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/

bookkeeper/docker/Dockerfile

Line 68 in 1e3efa1

ENTRYPOINT [ "/bin/bash", "/opt/bookkeeper/scripts/entrypoint.sh" ]

bookkeeper/docker/scripts/entrypoint.sh

Line 58 in 1e3efa1

run_command /opt/bookkeeper/bin/bookkeeper bookie

```
Now we can start our Bookkeeper ensemble (e.g. with three bookies):
```
Expand Down
Loading