chore: Update python files #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pip - cargo and fix few small issues.
milenkovicm
force-pushed
the
chore_python_cleanup
branch
from
430093c to
2e7ab1c
Compare
tbar4
reviewed
Nov 27, 2024
| .standalone() | ||
|
|
||
| #ctx_remote: SessionContext = ballista.remote("remote_ip", 50050) |
There was a problem hiding this comment.
Didn't know if we wanted to show an example of connecting to a remote instance, but it is covered in the other docs anyway, so good call removing.
tbar4
reviewed
Nov 27, 2024
| build-backend = "maturin" | ||
|
|
||
| [project] | ||
| name = "ballista" | ||
| description = "Python client for Apache Arrow Ballista Distributed SQL Query Engine" | ||
| readme = "README.md" | ||
| license = {file = "LICENSE.txt"} | ||
| requires-python = ">=3.6" | ||
| requires-python = ">=3.7" |
tbar4
reviewed
Nov 27, 2024
| @@ -66,7 +63,11 @@ impl PyBallistaBuilder { | |||
| /// Construct the standalone instance from the SessionContext | |||
| pub fn standalone(&self, py: Python) -> PyResult<PySessionContext> { | |||
| // Build the config | |||
| let config: SessionConfig = SessionConfig::from_string_hash_map(&self.conf)?; | |||
| let mut config: SessionConfig = SessionConfig::new_with_ballista(); | |||
There was a problem hiding this comment.
Did you update something in new_with_ballista? When I initially tried this I was getting an error. If it works thatn that is great!
There was a problem hiding this comment.
Changed nothing
tbar4
reviewed
Nov 27, 2024
python/src/utils.rs
Outdated
There was a problem hiding this comment.
This was initially used when awaiting the old BallistaContext. I think we could remove if needed. I left it in because I was unsure if we would need it again, but at this point I think we could just delete.
tbar4
approved these changes
Nov 27, 2024
tbar4
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update pip dependencies, pyproject and cargo, also added fix few small issues.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?