Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update python files #1141

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ datafusion-python = { version = "42" }

pyo3 = { version = "0.22", features = ["extension-module", "abi3", "abi3-py38"] }
pyo3-log = "0.11.0"
tokio = { version = "1.35", features = ["macros", "rt", "rt-multi-thread", "sync"] }
tokio = { version = "1.41", features = ["macros", "rt", "rt-multi-thread", "sync"] }

[lib]
crate-type = ["cdylib"]
Expand Down
4 changes: 2 additions & 2 deletions python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ from ballista import BallistaBuilder
## Example SQL Usage

```python
>>> ctx.sql("create external table t stored as parquet location '/mnt/bigdata/tpch/sf10-parquet/lineitem.parquet'")
>>> ctx.sql("create external table t stored as parquet location './testdata/test.parquet'")
>>> df = ctx.sql("select * from t limit 5")
>>> pyarrow_batches = df.collect()
```

## Example DataFrame Usage

```python
>>> df = ctx.read_parquet('/mnt/bigdata/tpch/sf10-parquet/lineitem.parquet').limit(5)
>>> df = ctx.read_parquet('./testdata/test.parquet').limit(5)
>>> pyarrow_batches = df.collect()
```

Expand Down
8 changes: 4 additions & 4 deletions python/examples/example.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@
# specific language governing permissions and limitations
# under the License.

# %%

from ballista import BallistaBuilder
from datafusion.context import SessionContext

# Ballista will initiate with an empty config
# set config variables with `config`
ctx: SessionContext = BallistaBuilder()\
.config("ballista.job.name", "example ballista")\
.config("ballista.shuffle.partitions", "16")\
.config("datafusion.execution.target_partitions", "4")\
.standalone()

#ctx_remote: SessionContext = ballista.remote("remote_ip", 50050)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know if we wanted to show an example of connecting to a remote instance, but it is covered in the other docs anyway, so good call removing.


# Select 1 to verify its working
ctx.sql("SELECT 1").show()
#ctx_remote.sql("SELECT 2").show()
# %%
37 changes: 37 additions & 0 deletions python/examples/readme.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

# %%

from ballista import BallistaBuilder
from datafusion.context import SessionContext

ctx: SessionContext = BallistaBuilder()\
.config("ballista.job.name", "Readme Examples")\
.config("datafusion.execution.target_partitions", "4")\
.standalone()
ctx.sql("create external table t stored as parquet location '../testdata/test.parquet'")

# %%
df = ctx.sql("select * from t limit 5")
pyarrow_batches = df.collect()
pyarrow_batches[0].to_pandas()
# %%
df = ctx.read_parquet('../testdata/test.parquet').limit(5)
pyarrow_batches = df.collect()
pyarrow_batches[0].to_pandas()
# %%
4 changes: 2 additions & 2 deletions python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@
# under the License.

[build-system]
requires = ["maturin>=0.15,<0.16"]
requires = ["maturin>=1.5.1,<1.6.0"]
build-backend = "maturin"

[project]
name = "ballista"
description = "Python client for Apache Arrow Ballista Distributed SQL Query Engine"
readme = "README.md"
license = {file = "LICENSE.txt"}
requires-python = ">=3.6"
requires-python = ">=3.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would conclict with #1136 so I will change it really quick and repush my branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated #1136 to require python 3.7 or greater

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datafusion python has python > 3.7

keywords = ["ballista", "sql", "rust", "distributed"]
classifier = [
"Development Status :: 2 - Pre-Alpha",
Expand Down
3 changes: 2 additions & 1 deletion python/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
datafusion==35.0.0
datafusion==42.0.0
maturin==1.5.1
pyarrow
pytest
16 changes: 10 additions & 6 deletions python/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,9 @@ use datafusion::execution::SessionStateBuilder;
use datafusion::prelude::*;
use datafusion_python::context::PySessionContext;
use datafusion_python::utils::wait_for_future;

use std::collections::HashMap;

use pyo3::prelude::*;
use std::collections::HashMap;
mod utils;
use utils::to_pyerr;

#[pymodule]
fn ballista_internal(_py: Python, m: Bound<'_, PyModule>) -> PyResult<()> {
Expand Down Expand Up @@ -66,7 +63,11 @@ impl PyBallistaBuilder {
/// Construct the standalone instance from the SessionContext
pub fn standalone(&self, py: Python) -> PyResult<PySessionContext> {
// Build the config
let config: SessionConfig = SessionConfig::from_string_hash_map(&self.conf)?;
let mut config: SessionConfig = SessionConfig::new_with_ballista();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you update something in new_with_ballista? When I initially tried this I was getting an error. If it works thatn that is great!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed nothing

for (key, value) in &self.conf {
let _ = config.options_mut().set(&key, value);
}

// Build the state
let state = SessionStateBuilder::new()
.with_config(config)
Expand All @@ -85,7 +86,10 @@ impl PyBallistaBuilder {
/// Construct the remote instance from the SessionContext
pub fn remote(&self, url: &str, py: Python) -> PyResult<PySessionContext> {
// Build the config
let config: SessionConfig = SessionConfig::from_string_hash_map(&self.conf)?;
let mut config: SessionConfig = SessionConfig::new_with_ballista();
for (key, value) in &self.conf {
let _ = config.options_mut().set(&key, value);
}
// Build the state
let state = SessionStateBuilder::new()
.with_config(config)
Expand Down
1 change: 1 addition & 0 deletions python/src/utils.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was initially used when awaiting the old BallistaContext. I think we could remove if needed. I left it in because I was unsure if we would need it again, but at this point I think we could just delete.

Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ use ballista_core::error::BallistaError;
use pyo3::exceptions::PyException;
use pyo3::PyErr;

#[allow(dead_code)]
pub(crate) fn to_pyerr(err: BallistaError) -> PyErr {
PyException::new_err(err.to_string())
}